Mesh: Add versioning in 3.0 for vertex normal refactor
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jan 17 2022, 5:50 PM.

Details

Reviewers

Philipp Oeser (lichtwerk)
Campbell Barton (campbellbarton)

Commits

rBadd07576a090: Mesh: Add versioning in 3.0 for vertex normal refactor

Summary

This tags all meshes from the future 3.1 version dirty,
since normals aren't "implicitly" read as part of MVert
anymore.

The code change is straightforward here, I'm just making
a patch since I think that's the correct process for the 3.0 branch.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jan 17 2022, 5:50 PM

Hans Goudey (HooglyBoogly) created this revision.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

LGTM, would appreciate Campbell giving the green light

Works well, although this tags mesh->runtime.cd_dirty_poly is there any reason why polygons should be handled too?
If not, this could assign mesh->runtime.cd_dirty_vert |= CD_MASK_NORMAL.

Philipp Oeser (lichtwerk) mentioned this in T93479: 3.0 Potential candidates for corrective releases.Jan 20 2022, 4:54 PM

Use cd_dirty_vert explicitly instead

Campbell Barton (campbellbarton) accepted this revision.Jan 24 2022, 9:30 AM

This revision is now accepted and ready to land.Jan 24 2022, 9:30 AM

Campbell Barton (campbellbarton) added inline comments.Jan 24 2022, 9:31 AM

source/blender/blenloader/intern/versioning_300.c
64	This can be removed.

Closed by commit rBadd07576a090: Mesh: Add versioning in 3.0 for vertex normal refactor (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJan 24 2022, 5:29 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBadd07576a090: Mesh: Add versioning in 3.0 for vertex normal refactor.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenloader/

intern/

versioning_300.c

10 lines

Diff 47383

View Options

source/blender/blenloader/intern/versioning_300.c

Mesh: Add versioning in 3.0 for vertex normal refactorClosedPublicActions