Differential D13863
CMake: create readme.html with configure_file Authored by Ankit Meel (ankitm) on Jan 18 2022, 8:18 AM. Tags Subscribers None
Details Create readme.html using configure_file:
Since the output file stays unmodified for most developer runs, Also don't re-implement what CMake can do. Will need to test the remove_recurse part, so will not land that piece of code now. I had posted this diff to use phab as git stash but here we are (:
Diff Detail Event Timeline
Comment Actions Patch description could use some work though, the commit message has to be better than this. Comment Actions *Edit* I had a concern about this being moved out of the install target into the CMake configuration step. It turns out this is reliable (updating the version number in BKE_blender_version.h is guaranteed to re-run CMake), so there are no problems with the readme.html not explicitly depending on BKE_blender_version.h. If the user manually removes readme.html the install target will fail but developers shouldn't be manually removing files created by CMake in the build directory so I don't think it's a problem. If for some reason this ends up causing problems we could always move the configure_file(...) inside an install(CODE ...) command.
Comment Actions @Ankit Meel (ankitm) I missed the removal of "file(REMOVE_RECURSE ${TARGETDIR_VER})" as far as I can see this is still important to keep for the reason noted in the comment, surely configure_file(..) can be made to work without such a big change. Comment Actions Yes that's unrelated. As said it was a personal stash before I discarded local changes. Was not ready for review when reviewers were added. | ||||||||||||