Paths

Table of Contentst

Differential D13869

Cleanup: Correct location of node function declarations
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jan 18 2022, 7:09 PM.

Tags

Subscribers

None

Details

Reviewers

Jacques Lucke (JacquesLucke)
Jeroen Bakker (jbakker)

Commits

rB2bf519d211b1: Cleanup: Correct location of node function declarations

Summary

Currently there are many function declarations in BKE_node.h that
don't actually have implementations in blenkernel. This commit moves
the declarations to NOD_composite.h, NOD_texture.h, and
NOD_shader.h instead. This helps to clarify the purpose of the
different modules.

Conceptually, the node type defines should probably be moved to DNA,
but it's questionable whether that change is worth it at this point.

Diff Detail

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jan 18 2022, 7:09 PM

Hans Goudey (HooglyBoogly) created this revision.

Jacques Lucke (JacquesLucke) accepted this revision.Jan 20 2022, 5:32 PM

Jeroen Bakker (jbakker) accepted this revision.Jan 24 2022, 2:14 PM

This revision is now accepted and ready to land.Jan 24 2022, 2:14 PM

Closed by commit rB2bf519d211b1: Cleanup: Correct location of node function declarations (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJan 24 2022, 11:20 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB2bf519d211b1: Cleanup: Correct location of node function declarations.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

111 lines

intern/

node_tree_update.cc

1 line

2 lines

blenloader/

intern/

versioning_260.c

1 line

versioning_cycles.c

2 lines

compositor/

nodes/

COM_CryptomatteNode.cc

5 lines

operations/

COM_TextureOperation.cc

2 lines

editors/

interface/

interface_eyedropper_color.c

2 lines

render/

1 line

render_internal.cc

2 lines

render_shading.cc

2 lines

render_update.cc

2 lines

sculpt_paint/

1 line

2 lines

2 lines

2 lines

gpu/

intern/

2 lines

makesrna/

intern/

2 lines

1 line

2 lines

nodes/

NOD_composite.h

69 lines

22 lines

16 lines

render/

intern/

2 lines

texture_procedural.c

8 lines

Diff 47226

source/blender/blenkernel/BKE_node.h

Loading...

source/blender/blenkernel/intern/node_tree_update.cc

Loading...

source/blender/blenkernel/intern/texture.c

Loading...

source/blender/blenloader/intern/versioning_260.c

Loading...

source/blender/blenloader/intern/versioning_cycles.c

Loading...

source/blender/compositor/nodes/COM_CryptomatteNode.cc

Loading...

source/blender/compositor/operations/COM_TextureOperation.cc

Loading...

source/blender/editors/interface/interface_eyedropper_color.c

Loading...

source/blender/editors/render/CMakeLists.txt

Loading...

source/blender/editors/render/render_internal.cc

Loading...

source/blender/editors/render/render_shading.cc

Loading...

source/blender/editors/render/render_update.cc

Loading...

source/blender/editors/sculpt_paint/CMakeLists.txt

Loading...

source/blender/editors/sculpt_paint/paint_cursor.c

Loading...

source/blender/editors/sculpt_paint/paint_image.c

Loading...

source/blender/editors/sculpt_paint/sculpt.c

Loading...

source/blender/gpu/intern/gpu_material.c

Loading...

source/blender/makesrna/intern/rna_layer.c

Loading...

source/blender/makesrna/intern/rna_nodetree.c

Loading...

source/blender/makesrna/intern/rna_scene.c

Loading...

source/blender/nodes/NOD_composite.h

Loading...

source/blender/nodes/NOD_shader.h

Loading...

source/blender/nodes/NOD_texture.h

Loading...

source/blender/render/intern/pipeline.c

Loading...

source/blender/render/intern/texture_procedural.c

Loading...