Page MenuHome
Differential D13870

GPencil: Avoid drift in Sculpt when mouse/pen is not moved
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Jan 18 2022, 7:58 PM.

Details

Reviewers
Richard Antalik (ISS)
Commits
rB824f514f8f63: Fix T94860: GPencil - Avoid drift in Sculpt when mouse/pen is not moved
Summary

Related to T94860

This fix avoid the drif checking if the previous position is equals to new one, in this case, the pen has not moved and can be canceled.

Diff Detail

Repository
rB Blender

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Jan 18 2022, 7:58 PM
Antonio Vazquez (antoniov) created this revision.
Harbormaster completed remote builds in B20068: Diff 47227.Jan 18 2022, 7:58 PM
Antonio Vazquez (antoniov) added a reviewer: Richard Antalik (ISS).Jan 18 2022, 8:00 PM
Antonio Vazquez (antoniov) added a project: Grease Pencil.

@Richard Antalik (ISS) we need someone with a tablet to confirm my fix. I have tested, but better to have a second opinion.

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Jan 18 2022, 8:01 PM
Antonio Vazquez (antoniov) retitled this revision from GPencil: Avoid drift in Sculpt when mouse is not moved to GPencil: Avoid drift in Sculpt when mouse/pen is not moved.
Antonio Vazquez (antoniov) added a subscriber: Philipp Oeser (lichtwerk).Jan 20 2022, 9:56 AM

@Philipp Oeser (lichtwerk) What do you think of the patch? do you have a tablet to test?

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2022, 10:51 AM
Closed by commit rB824f514f8f63: Fix T94860: GPencil - Avoid drift in Sculpt when mouse/pen is not moved (authored by Antonio Vazquez (antoniov)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rB824f514f8f63: Fix T94860: GPencil - Avoid drift in Sculpt when mouse/pen is not moved.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
6 lines

Diff 48269

View Options

source/blender/editors/gpencil/gpencil_sculpt_paint.c

Loading...