Cycles: Fix T94736: Crash when modifying strength of world environment texture
ClosedPublic
Actions

Authored by Michael Jones (michael_jones) on Jan 19 2022, 6:58 PM.

Details

Reviewers

Commits

rC20cc512a7852: Fix t94736: crash when modifying strength of world environment texture
rB17cab47ed10a: Cycles: Fix T94736: Crash when modifying strength of world environment texture

Summary

This patch fixes crash T94736 on Metal in which the launch_params were not being updated to reflect destruction of MetalMem objects.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 20074
Build 20074: arc lint + arc unit

Event Timeline

Michael Jones (michael_jones) requested review of this revision.Jan 19 2022, 6:58 PM

Michael Jones (michael_jones) created this revision.

Harbormaster completed remote builds in B20074: Diff 47241.Jan 19 2022, 6:58 PM

Brecht Van Lommel (brecht) accepted this revision.Jan 19 2022, 7:11 PM

This revision is now accepted and ready to land.Jan 19 2022, 7:11 PM

Closed by commit rB17cab47ed10a: Cycles: Fix T94736: Crash when modifying strength of world environment texture (authored by Michael Jones (michael_jones)). · Explain WhyJan 19 2022, 7:17 PM

This revision was automatically updated to reflect the committed changes.

Michael Jones (michael_jones) added a commit: rB17cab47ed10a: Cycles: Fix T94736: Crash when modifying strength of world environment texture.

Brecht Van Lommel (brecht) added a commit: rC20cc512a7852: Fix t94736: crash when modifying strength of world environment texture.Jan 27 2022, 11:38 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

device/

metal/

device_impl.h

2 lines

device_impl.mm

30 lines

Diff 47241

View Options

intern/cycles/device/metal/device_impl.h