Fix T95177: OpenSubdiv Crash using mirror modifier in edit-mode
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Jan 24 2022, 1:30 PM.

Details

Reviewers: None

Summary

There were some cases where Edit-mesh with opensubdiv assumed the underlying mesh was aligned with the edit mesh.

This is not the case with multiple modifiers in the stack, as shown in T95177.

*Edit*, after posting this diff I noticed original indices (while not crashing) aren't working properly, selection and selected face display for example are not working.

So I'll close this diff as it's not ready for review.

Diff Detail

Repository

rB Blender

Branch

TEMP-T95177-FIX (branched from master)

Build Status

Buildable 20126
Build 20126: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Jan 24 2022, 1:30 PM

Campbell Barton (campbellbarton) created this revision.

Harbormaster completed remote builds in B20126: Diff 47373.Jan 24 2022, 1:30 PM

Campbell Barton (campbellbarton) abandoned this revision.Jan 24 2022, 1:36 PM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_impl_subdivision.cc

3 lines

mesh_extractors/

extract_mesh_vbo_edit_data.cc

10 lines

Diff 47373

View Options

source/blender/draw/intern/draw_cache_impl_subdivision.cc