Details

Reviewers

Clément Foucault (fclem)

Commits

rB3f42417cd4c8: Draw: Migrate hair refine compute shader to use create info.

Summary

This patch migrates the draw manager hair refine compute shader to use
GPUShaderCreateInfo.

Diff Detail

Repository

rB Blender

Branch

temp-draw-manager-hair-refine (branched from master)

Build Status

Buildable 20157
Build 20157: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jan 25 2022, 2:03 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B20157: Diff 47419.Jan 25 2022, 2:03 PM

Jeroen Bakker (jbakker) added a parent revision: D13910: Workbench: Port shaders to use GPUShaderCreateInfo.Jan 25 2022, 2:03 PM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).

Jeroen Bakker (jbakker) added a project: EEVEE & Viewport.

Jeroen Bakker (jbakker) added inline comments.

source/blender/gpu/intern/gpu_shader_log.cc
106	Revert this change

Jeroen Bakker (jbakker) marked an inline comment as not done.Jan 25 2022, 2:04 PM

Revert unneeded change.

Harbormaster completed remote builds in B20158: Diff 47420.Jan 25 2022, 2:07 PM

Jeroen Bakker (jbakker) added inline comments.Jan 25 2022, 2:09 PM

source/blender/gpu/intern/gpu_shader_create_info.hh
246	Could have used 0, but think that should be handled by the compiler.

Remove unused code.
Remove local_group_size from GPUShaderCreateInfo.

Harbormaster completed remote builds in B20159: Diff 47421.Jan 25 2022, 2:16 PM

Revert unneeded change.
Remove unused code.
Remove local_group_size from GPUShaderCreateInfo.
Use GPU_shader_create_from_info_name.
Renamed API to local_group_size.

Harbormaster completed remote builds in B20160: Diff 47423.Jan 25 2022, 2:33 PM

Jeroen Bakker (jbakker) removed a parent revision: D13910: Workbench: Port shaders to use GPUShaderCreateInfo.Jan 25 2022, 2:33 PM

Copy local_size when using additional_info.

Harbormaster completed remote builds in B20161: Diff 47424.Jan 25 2022, 2:37 PM

Remove empty line.

Harbormaster completed remote builds in B20162: Diff 47425.Jan 25 2022, 2:38 PM

Clément Foucault (fclem) accepted this revision.Jan 25 2022, 2:39 PM

Clément Foucault (fclem) added inline comments.

source/blender/gpu/intern/gpu_shader_create_info.hh
246	Yes, if ommitted, the dimension is set to 1.

This revision is now accepted and ready to land.Jan 25 2022, 2:39 PM

Jeroen Bakker (jbakker) marked an inline comment as done.Jan 25 2022, 2:45 PM

Closed by commit rB3f42417cd4c8: Draw: Migrate hair refine compute shader to use create info. (authored by Jeroen Bakker (jbakker)). · Explain WhyJan 25 2022, 2:47 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB3f42417cd4c8: Draw: Migrate hair refine compute shader to use create info..

Draw: Migrate hair refine compute shader to use create info.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 47419

source/blender/draw/intern/draw_hair.c

source/blender/draw/intern/draw_shader.c

source/blender/draw/intern/shaders/common_hair_lib.glsl

source/blender/draw/intern/shaders/common_hair_refine_comp.glsl

source/blender/draw/intern/shaders/draw_hair_refine_info.hh

source/blender/gpu/CMakeLists.txt

source/blender/gpu/intern/gpu_shader.cc

source/blender/gpu/intern/gpu_shader_create_info.hh

source/blender/gpu/intern/gpu_shader_log.cc

source/blender/gpu/intern/gpu_shader_private.hh

source/blender/gpu/opengl/gl_shader.hh

source/blender/gpu/opengl/gl_shader.cc

Draw: Migrate hair refine compute shader to use create info.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47419

source/blender/draw/intern/draw_hair.c

source/blender/draw/intern/draw_shader.c

source/blender/draw/intern/shaders/common_hair_lib.glsl

source/blender/draw/intern/shaders/common_hair_refine_comp.glsl

source/blender/draw/intern/shaders/draw_hair_refine_info.hh

source/blender/gpu/CMakeLists.txt

source/blender/gpu/intern/gpu_shader.cc

source/blender/gpu/intern/gpu_shader_create_info.hh

source/blender/gpu/intern/gpu_shader_log.cc

source/blender/gpu/intern/gpu_shader_private.hh

source/blender/gpu/opengl/gl_shader.hh

source/blender/gpu/opengl/gl_shader.cc

Draw: Migrate hair refine compute shader to use create info.
ClosedPublic
Actions

Revision Contents
Changeset List