Define CLANG_FORMAT_VERSION in install_deps.sh
ClosedPublic
Actions

Authored by Michael (michael64) on Jan 26 2022, 10:12 AM.

Details

Reviewers

Bastien Montagne (mont29)

Commits

rBb22db23aee11: Define CLANG_FORMAT_VERSION in install_deps.sh

Summary

When running ./blender/build_files/build_environment/install_deps.sh on Ubuntu 20.04.3 LTS the following error can be seen:

./blender/build_files/build_environment/install_deps.sh: line 1266: [: too many arguments

This error results from the call:

check_package_version_ge_DEB $CLANG_FORMAT $CLANG_FORMAT_VERSION

with CLANG_FORMAT_VERSION being undefined.
Also as clang-format 13 is already released and hopefully didn't break anything CLANG_FORMAT_VERSION_MEX could use version bump.

Diff Detail

Event Timeline

Michael (michael64) requested review of this revision.Jan 26 2022, 10:12 AM

Michael (michael64) created this revision.

Ankit Meel (ankitm) added a reviewer: Bastien Montagne (mont29).Jan 28 2022, 6:03 PM

Ankit Meel (ankitm) added a subscriber: Ankit Meel (ankitm).

Bastien Montagne (mont29) accepted this revision.Jan 28 2022, 6:09 PM

This revision is now accepted and ready to land.Jan 28 2022, 6:09 PM

Eeeh the patch does not apply anymore, which means I cannot commit it on your behalf (keeping you as author of the change). Mind updating it against latest master? thanks.

This revision now requires changes to proceed.Feb 15 2022, 12:41 PM

Updated the context surrounding the changed lines.

Bastien Montagne (mont29) accepted this revision.Feb 15 2022, 2:11 PM

This revision is now accepted and ready to land.Feb 15 2022, 2:11 PM

Thanks!

Closed by commit rBb22db23aee11: Define CLANG_FORMAT_VERSION in install_deps.sh (authored by Michael - (michael), committed by Bastien Montagne (mont29)). · Explain WhyFeb 15 2022, 2:13 PM

This revision was automatically updated to reflect the committed changes.

Bastien Montagne (mont29) added a commit: rBb22db23aee11: Define CLANG_FORMAT_VERSION in install_deps.sh.