Page MenuHome

Fix T94900: Sequence drawing artifacts.
AbandonedPublic

Authored by Jeroen Bakker (jbakker) on Jan 26 2022, 1:49 PM.

Details

Summary

The VSE only uses an overlay buffer to draw to the screen. The
GPUViewport assumes that platforms clears textures during creation, but
they do not on selected platforms. What would lead to drawing from
uncleared memory.

By selecting which buffers would contain correct data allows us to use
dummy textures in these cases that would eliminate the drawing
artifacts.

I chose for having a default_buffers parameter in the viewport otherwise
this fix would have code changes in window manager what should not be
aware of how viewports are being used.

Diff Detail

Repository
rB Blender
Branch
temp-T94900-gpu-viewport-default-layers
Build Status
Buildable 20182
Build 20182: arc lint + arc unit

Event Timeline

  • Cleanup of previous commit.
  • Cleanup of previous commit.
  • Cleanup of previous commit.
Jeroen Bakker (jbakker) requested review of this revision.Jan 26 2022, 2:06 PM
Jeroen Bakker (jbakker) retitled this revision from T94900: Sequence drawing errors on selected platforms. to T94900: Sequence drawing artifacts..
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)
Jeroen Bakker (jbakker) retitled this revision from T94900: Sequence drawing artifacts. to Fix T94900: Sequence drawing artifacts..
Jeroen Bakker (jbakker) planned changes to this revision.Jan 26 2022, 2:21 PM

Clear textures when creating the viewport.

Different solution is in master.