Paths

Table of Contentst

Differential D13929

Cleanup: Cmake: remove unnecessary definitions for internationalization
ClosedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Jan 26 2022, 9:13 PM.

Tags

Subscribers

Ankit Meel (ankitm)

Details

Reviewers

Bastien Montagne (mont29)
Ray Molenkamp (LazyDodo)

Commits

rBe951e81b0f66: Cleanup: Cmake: remove unnecessary definitions for internationalization

Summary

Previously, macros were ifdefed using the cmake option WITH_INTERNATIONAL
However, the is unnecessary as withen the functions themselves have checks for building without internationalization.
This also means that many add_definitions(-DWITH_INTERNATIONAL) are also unnecessary.

Diff Detail

Repository

Branch

cmake-lib-blt (branched from master)

Build Status

Buildable 20230
Build 20230: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Jan 26 2022, 9:13 PM

Aaron Carlisle (Blendify) created this revision.

Harbormaster completed remote builds in B20186: Diff 47483.Jan 26 2022, 9:13 PM

Aaron Carlisle (Blendify) added reviewers: Bastien Montagne (mont29), Ray Molenkamp (LazyDodo).Jan 26 2022, 9:18 PM

Aaron Carlisle (Blendify) added projects: BF Blender, Translations.

Aaron Carlisle (Blendify) added 1 blocking reviewer(s): Bastien Montagne (mont29).Jan 26 2022, 9:25 PM

Ankit Meel (ankitm) added a subscriber: Ankit Meel (ankitm).Jan 27 2022, 7:26 AM

Think the idea when this was added was that you would not even have to call those functions at all, even if they were defined as a simple return...

But agree this is just bloating the CMake files for nothing really.

This revision is now accepted and ready to land.Jan 27 2022, 9:16 AM

blender\source\blender\windowmanager\CMakeLists.txt can be done as well, it only has one call that has the guard (BLT_lang_free) that has a guard of its own.

source/blender/editors/space_view3d/CMakeLists.txt uses it to determine a buffer size, it's a ~60 byte difference on the stack.. just always use the larger buffer...

source/creator/CMakeLists.txt can be cleaned, it's not using it at all

there may be a few others but i ran out of time tonight, will pick this up again this weekend.

Ray Molenkamp (LazyDodo) requested changes to this revision.Jan 28 2022, 6:23 AM

This revision now requires changes to proceed.Jan 28 2022, 6:23 AM

Merge branch 'master' into cmake-lib-blt
Cleanup: Remove more instances of DWITH_INTERNATIONAL

Harbormaster completed remote builds in B20230: Diff 47721.Jan 29 2022, 7:45 PM

Look at all that glorious red, well done @Aaron Carlisle (Blendify)! much appreciated !

This revision is now accepted and ready to land.Jan 29 2022, 9:29 PM

Closed by commit rBe951e81b0f66: Cleanup: Cmake: remove unnecessary definitions for internationalization (authored by Aaron Carlisle (Blendify)). · Explain WhyJan 29 2022, 11:40 PM

This revision was automatically updated to reflect the committed changes.

Aaron Carlisle (Blendify) added a commit: rBe951e81b0f66: Cleanup: Cmake: remove unnecessary definitions for internationalization.

Revision Contents
Changeset List

Path

Size

intern/

locale/

1 line

source/

blender/

blenfont/

4 lines

blenkernel/

4 lines

blenloader/

4 lines

blentranslation/

BLT_translation.h

24 lines

bmesh/

4 lines

compositor/

4 lines

editors/

animation/

4 lines

armature/

4 lines

curve/

4 lines

gpencil/

4 lines

interface/

interface_style.c

5 lines

io/

4 lines

mesh/

4 lines

object/

4 lines

physics/

4 lines

render/

4 lines

scene/

3 lines

screen/

4 lines

sculpt_paint/

4 lines

space_buttons/

4 lines

space_clip/

5 lines

space_file/

4 lines

space_graph/

4 lines

space_image/

4 lines

space_info/

4 lines

space_nla/

4 lines

space_node/

4 lines

space_outliner/

4 lines

space_sequencer/

4 lines

space_text/

3 lines

space_view3d/

5 lines

4 lines

transform/

4 lines

undo/

4 lines

util/

4 lines

uvedit/

4 lines

freestyle/

4 lines

gpencil_modifiers/

4 lines

io/

collada/

4 lines

modifiers/

4 lines

nodes/

4 lines

composite/

4 lines

function/

4 lines

geometry/

4 lines

shader/

4 lines

texture/

3 lines

render/

4 lines

shader_fx/

4 lines

windowmanager/

4 lines

intern/

2 lines

Diff 47721

intern/locale/CMakeLists.txt

Loading...

source/blender/blenfont/CMakeLists.txt

Loading...

source/blender/blenkernel/CMakeLists.txt

Loading...

source/blender/blenloader/CMakeLists.txt

Loading...

source/blender/blentranslation/BLT_translation.h

Loading...

source/blender/bmesh/CMakeLists.txt

Loading...

source/blender/compositor/CMakeLists.txt

Loading...

source/blender/editors/animation/CMakeLists.txt

Loading...

source/blender/editors/armature/CMakeLists.txt

Loading...

source/blender/editors/curve/CMakeLists.txt

Loading...

source/blender/editors/gpencil/CMakeLists.txt

Loading...

source/blender/editors/interface/interface_style.c

Loading...

source/blender/editors/io/CMakeLists.txt

Loading...

source/blender/editors/mesh/CMakeLists.txt

Loading...

source/blender/editors/object/CMakeLists.txt

Loading...

source/blender/editors/physics/CMakeLists.txt

Loading...

source/blender/editors/render/CMakeLists.txt

Loading...

source/blender/editors/scene/CMakeLists.txt

Loading...

source/blender/editors/screen/CMakeLists.txt

Loading...

source/blender/editors/sculpt_paint/CMakeLists.txt

Loading...

source/blender/editors/space_buttons/CMakeLists.txt

Loading...

source/blender/editors/space_clip/CMakeLists.txt

Loading...

source/blender/editors/space_file/CMakeLists.txt

Loading...

source/blender/editors/space_graph/CMakeLists.txt

Loading...

source/blender/editors/space_image/CMakeLists.txt

Loading...

source/blender/editors/space_info/CMakeLists.txt

Loading...

source/blender/editors/space_nla/CMakeLists.txt

Loading...

source/blender/editors/space_node/CMakeLists.txt

Loading...

source/blender/editors/space_outliner/CMakeLists.txt

Loading...

source/blender/editors/space_sequencer/CMakeLists.txt

Loading...

source/blender/editors/space_text/CMakeLists.txt

Loading...

source/blender/editors/space_view3d/CMakeLists.txt

Loading...

source/blender/editors/space_view3d/view3d_draw.c

Loading...

source/blender/editors/transform/CMakeLists.txt

Loading...

source/blender/editors/undo/CMakeLists.txt

Loading...

source/blender/editors/util/CMakeLists.txt

Loading...

source/blender/editors/uvedit/CMakeLists.txt

Loading...

source/blender/freestyle/CMakeLists.txt

Loading...

source/blender/gpencil_modifiers/CMakeLists.txt

Loading...

source/blender/io/collada/CMakeLists.txt

Loading...

source/blender/modifiers/CMakeLists.txt

Loading...

source/blender/nodes/CMakeLists.txt

Loading...

source/blender/nodes/composite/CMakeLists.txt

Loading...

source/blender/nodes/function/CMakeLists.txt

Loading...

source/blender/nodes/geometry/CMakeLists.txt

Loading...

source/blender/nodes/shader/CMakeLists.txt

Loading...

source/blender/nodes/texture/CMakeLists.txt

Loading...

source/blender/render/CMakeLists.txt

Loading...

source/blender/shader_fx/CMakeLists.txt

Loading...

source/blender/windowmanager/CMakeLists.txt

Loading...

source/blender/windowmanager/intern/wm_init_exit.c

Loading...