Fix T94692: Show Cached OneDrive Thumbnails
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Jan 26 2022, 11:18 PM.

Details

Reviewers

Julian Eisel (Severin)

Maniphest Tasks

T94692: Thumbnails are not shown for offline files in OneDrive

Commits

rBbd9f94e91720: Fix T94692: Show Cached OneDrive Thumbnails

Summary

When OneDrive files are offline, show preexisting thumbnails.

D11101: Fix T87621: Win32 Do Not Create Preview Thumbnails for Offline Files made it so that offline OneDrive files are not thumbnailed. This is because the act of creating a thumbnail will force the item to be brought online, which can be a lengthy process.

But that solution was a bit overzealous. It also made it so that offline files would not show thumbnails, even if they already exist. This patch changes that so any existing thumbnail will be shown even if a new one will not be created when offline. This means you can bring your files online once, let thumbnails be created, then take them offline and still get previews to help indicate the contents.

Diff Detail

Repository: rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Jan 26 2022, 11:18 PM

Harley Acheson (harley) created this revision.

Harley Acheson (harley) added a task: T94692: Thumbnails are not shown for offline files in OneDrive.

Thumbnail loading from the drive shouldn't be done in the main thread, so the IMB_thumb_read() call should be done inside filelist_cache_preview_runf().

Julian Eisel (Severin) requested changes to this revision.Jan 27 2022, 3:06 PM

This revision now requires changes to proceed.Jan 27 2022, 3:06 PM

In D13930#370301, @Julian Eisel (Severin) wrote:

Thumbnail loading from the drive shouldn't be done in the main thread, so the IMB_thumb_read() call should be done inside filelist_cache_preview_runf().

Thanks! I think I have a version of this patch that did that, but wasn’t sure which was better.