Page MenuHome

Very first step to handle missing libs/datablocks when reading a file.
ClosedPublic

Authored by Campbell Barton (campbellbarton) on Jul 6 2015, 10:57 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Bastien Montagne (mont29) retitled this revision from to Very first step to handle missing libs/datablocks when reading a file..
Bastien Montagne (mont29) updated this object.

If it's not for real review you can apply the following action: Plan Changes. So reviewers are not getting confused by this revision.

Bastien Montagne (mont29) planned changes to this revision.Jul 8 2015, 12:51 PM

Eh, OK, but still would like review of the idea itself ;)

This revision was automatically updated to reflect the committed changes.

Master-ready patch (hopefully!).

Merge branch 'master' into missing-libs

Merge branch 'master' into missing-libs

Campbell Barton (campbellbarton) added inline comments.
source/blender/blenloader/intern/readfile.c
10102

Error could be less dramatic and more descriptive :)

Also could have BLI_assert(0) here?

source/blender/makesdna/DNA_ID.h
277–294

This entire block should have comprehensive comments for each enum, even though most dont. It would be good to include a discription of LIB_MISSING here.

  • Merge branch 'master' into missing-libs
  • Move memory-zero-checking to BLI_memory_utils
  • Cleanup: naming, typo
  • Minor changes & sync with master

Only mentioned 2 very minor points, otherwise, think this is ready for master,

This revision was automatically updated to reflect the committed changes.