Page MenuHome

Fix GPencil Randomize brush when camera is too close
Needs ReviewPublic

Authored by Antonio Vazquez (antoniov) on Jan 28 2022, 6:30 PM.
This revision needs review, but all reviewers have resigned.

Details

Summary

The problem is the function ED_view3d_calc_zfac was returning that GP object is behind the camera and this avoided the sculpt action.

After checking, it looks the check is not necessary and this solves the issue.

Diff Detail

Repository
rB Blender
Branch
temp-T87647 (branched from master)
Build Status
Buildable 20214
Build 20214: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Jan 28 2022, 6:30 PM
Antonio Vazquez (antoniov) created this revision.

The flipping was introduced with rBa12d42712bae: Fix T47772: Randomize stroke has direction bias. Are we sure T47772 is still OK if we remove it?

Sorry @Antonio Vazquez (antoniov), I think it might work better if gpencil review is somehow organized differently [without me :)] since this regularly slips under my radar.
Always feel free to ping me (but having me as a sole reviewer is probably not the best idea in terms of organizing the module)