Fix T94287: gaps between strips when adding movies
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Jan 29 2022, 12:40 AM.

Details

Reviewers

Sergey Sharybin (sergey)
Sebastian Parborg (zeddb)

Maniphest Tasks

T94287: There is a gap in front of the video clip

Commits

rB68c2650b03f4: Fix T94287: gaps between strips when adding movies

Summary

Currently, audio and video strips are synchronized based on data from
media stream, which is nice, but this causes gaps between strips.
This synchronization was implemented by moving movie strip position
relative to sound, which doesn't make much sense for user which is
mostly interested in editing video.

Code was bit hard to read, so it has been simplified. Ideally video
stream time would be easily accessible so synchronization could be done
at any time, but this is not necessary at this point.

If I am not mistaken, @Sebastian Parborg (zeddb) is author of this code so adding as reviewer in case I missed something.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jan 29 2022, 12:40 AM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B20224: Diff 47710.Jan 29 2022, 12:40 AM

Restore sound strip clamping

Harbormaster completed remote builds in B20225: Diff 47711.Jan 29 2022, 12:41 AM

@Sebastian Parborg (zeddb), Are you fine picking review here? Not really familiar with the details of the code, so it will be hard for me to review from possibly behavioral regressions point of view.

LGTM, thanks for the clean up of the code!

I agree that clipping does make sense.
It was changed to not clip so that we would mirror the playback in vlc and mpv.
There they play the audio "lead in" before they start playing the video.
Example files here: https://developer.blender.org/D11917#309457

However I only thought that non artificial video files would not have a big enough offset to produce gaps between strips in practice.

But as the bug this fixes shows otherwise, I think just clipping the start is the correct solution.

This revision is now accepted and ready to land.Jan 31 2022, 12:34 PM

Closed by commit rB68c2650b03f4: Fix T94287: gaps between strips when adding movies (authored by Richard Antalik (ISS)). · Explain WhyJan 31 2022, 10:31 PM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB68c2650b03f4: Fix T94287: gaps between strips when adding movies.