Page MenuHome

Fix T95356: Crash in armature edit mode and certain condition
ClosedPublic

Authored by Sergey Sharybin (sergey) on Jan 31 2022, 5:42 PM.

Details

Summary

Blender would have crashed when renaming bone in Edit Mode, Saving, and
than selecting/deselecting.

Caused by a mistake in the 0f89bcdbebf5: can not "short-circuit" the
CoW update if it was explicitly requested.

Safest for now solution seems to be to store whether the CoW component
has been explicitly tagged, so that the following configuration can be
supported:

DEG_id_tag_update(id, ID_RECALC_GEOMETRY);
DEG_id_tag_update(id, ID_RECALC_COPY_ON_WRITE);

Diff Detail

Repository
rB Blender
Branch
fix_T95356 (branched from master)
Build Status
Buildable 20250
Build 20250: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Jan 31 2022, 5:42 PM
Sergey Sharybin (sergey) created this revision.

Forgot about the special case for animation handling.

This revision is now accepted and ready to land.Jan 31 2022, 6:04 PM