FIX: T95135 Wrong exception thrown when calling bpy.ops.graph.euler_filter() operator without keyframes as mentioned by the philipp oeser this was not a bug but message can be improved. the bug was caused due to: If there is no...
ClosedPublic
Actions

Authored by sayed amin (sayed_amin) on Jan 31 2022, 6:43 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Maniphest Tasks

T95135: Wrong exception thrown when calling bpy.ops.graph.euler_filter() operator without keyframes

Commits

rBceea3d0f809b: Fix T95135: improve error filtering non-existant anim data

Summary

as mentioned by the philipp oeser this was not a bug but message can be improved.

Bug caused: If there is no animation at all, the operators poll will fail because of that, returning that generic message.
If there is animation data (but no Euler Rotation F-Curves), the operator will execute, but return early with a bit more descriptive message.

Solution : The message could be improved by calling CTX_wm_operator_poll_msg_set with a descriptive text in graphop_editable_keyframes_poll in case ANIM_animdata_filter returns zero items.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 20251
Build 20251: arc lint + arc unit

Event Timeline

sayed amin (sayed_amin) requested review of this revision.Jan 31 2022, 6:43 PM

sayed amin (sayed_amin) created this revision.

Harbormaster completed remote builds in B20251: Diff 47776.Jan 31 2022, 6:43 PM

Hi, please update the existing diff D13965 instead of submitting a fresh one.

sayed amin (sayed_amin) retitled this revision from Message improved: T95135 Wrong exception thrown when calling bpy.ops.graph.euler_filter() operator without keyframes as mentioned by the philipp oeser this was not a bug but message can be improved. the bug was caused due to: If there is no... to FIX: T95135 Wrong exception thrown when calling bpy.ops.graph.euler_filter() operator without keyframes as mentioned by the philipp oeser this was not a bug but message can be improved. the bug was caused due to: If there is no....

this is the latest version

sayed amin (sayed_amin) edited the summary of this revision. (Show Details)Feb 1 2022, 5:09 AM

Thanks for your patch @sayed amin (sayed_amin).

For future patches: please don't use the title as a text field, it is meant to really only be a title.

Please update the patch with a clear description of the issue, for a better overview of what you could put in there, check out https://wiki.blender.org/wiki/Process/Contributing_Code#Ingredients_of_a_Patch

Sybren A. Stüvel (sybren) edited reviewers, added: Sybren A. Stüvel (sybren); removed: Thomas Dinges (dingto), Philipp Oeser (lichtwerk), Christian F (Chryfi).Feb 18 2022, 4:20 PM

Sybren A. Stüvel (sybren) added a task: T95135: Wrong exception thrown when calling bpy.ops.graph.euler_filter() operator without keyframes.