Fix T95378: Seek problems when timecodes are used
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Jan 31 2022, 11:40 PM.

Details

Reviewers

Sebastian Parborg (zeddb)

Maniphest Tasks

T95378: Seek fails within first GOP when using timecodes

Commits

rB95fcb4184108: Fix T95378: Seek problems when timecodes are used

Summary

Function IMB_indexer_get_seek_pos() can return non 0 seek position for
frame index 0. This causes seeking to incorrect GOP and scanning ends
with failiure.

Hard-code first frame index seek position to 0.

Diff Detail

Repository

rB Blender

Branch

T95378 (branched from master)

Build Status

Buildable 20260
Build 20260: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jan 31 2022, 11:40 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B20260: Diff 47796.Jan 31 2022, 11:40 PM

Are you sure that the comment is correct?
To me it seems like the seek position could be non zero if the audio track starts before the video track.

So to get to frame "0" you would have to get a time code that is non zero.

Or perhaps I'm missing something here?

In D13974#371802, @Sebastian Parborg (zeddb) wrote:

Are you sure that the comment is correct?

I am never sure with ffmpeg, but when you think how seeking works, I am pretty confident, that this is correct for index 0. What I should do here is also comment on indexer code and find issue there too in case it's incorrect for next indexes.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 1 2022, 10:54 PM

Closed by commit rB95fcb4184108: Fix T95378: Seek problems when timecodes are used (authored by Richard Antalik (ISS)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB95fcb4184108: Fix T95378: Seek problems when timecodes are used.