Fix T95395: Dangling parent pointer when creating node group.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 1 2022, 4:40 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T95395: Crash making a node group with a frame

Commits

rB2bd71b49e793: Fix T95395: dangling parent pointer when creating node group

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 1 2022, 4:40 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B20274: Diff 47823.Feb 1 2022, 4:40 PM

Jacques Lucke (JacquesLucke) added a task: T95395: Crash making a node group with a frame.Feb 1 2022, 4:40 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

The fix makes sense.

I wonder if ideally we wouldn't even have the parent pointer, and the frame nodes would keep track of their children.

This revision is now accepted and ready to land.Feb 1 2022, 5:14 PM

I wonder if ideally we wouldn't even have the parent pointer, and the frame nodes would keep track of their children.

Both representations make sense, don't think one is necessarily better than the other. In the future we might define one as the "ground truth" and store the other one as derived data. And for the ground truth the current parent pointer is probably better.

Closed by commit rB2bd71b49e793: Fix T95395: dangling parent pointer when creating node group (authored by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 1 2022, 5:50 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB2bd71b49e793: Fix T95395: dangling parent pointer when creating node group.