Page MenuHome
Differential D13994

Fix T94435: Remove anonymous attributes when applying modifier.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 2 2022, 2:53 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T94435: Applying GN modifier with Capture Attribute node clutters resulting mesh with anonymous attributes
Commits
rB4be87e97f485: Fix T94435: remove anonymous attributes when applying modifier
Summary

Not sure if the fix needs more explanation.

Diff Detail

Repository
rB Blender
Branch
delete-anonymous-attributes-on-apply (branched from master)
Build Status
Buildable 20296
Build 20296: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 2 2022, 2:53 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B20296: Diff 47867.Feb 2 2022, 2:54 PM
Jacques Lucke (JacquesLucke) added a task: T94435: Applying GN modifier with Capture Attribute node clutters resulting mesh with anonymous attributes.Feb 2 2022, 2:55 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Feb 2 2022, 3:01 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Hans Goudey (HooglyBoogly) accepted this revision.Feb 2 2022, 3:37 PM
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/blenkernel/intern/customdata.cc
2785

Hmm, theoretically there would be other ways to implement this without a while loop, but that doesn't look worth it, since CustomData_free_layer handles many other things too.

This revision is now accepted and ready to land.Feb 2 2022, 3:37 PM
Closed by commit rB4be87e97f485: Fix T94435: remove anonymous attributes when applying modifier (authored by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 3 2022, 4:59 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB4be87e97f485: Fix T94435: remove anonymous attributes when applying modifier.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
5 lines
intern/
18 lines
editors/
object/
6 lines

Diff 47867

View Options

source/blender/blenkernel/BKE_customdata.h

Loading...
View Options

source/blender/blenkernel/intern/customdata.cc

Loading...
View Options

source/blender/editors/object/object_modifier.c

Loading...