macOS: allow building blender-thumbnailer
ClosedPublic
Actions

@Campbell Barton (campbellbarton) this fixes the linker error.. do we want to enable the thumbnailer ? I can look into quicklook preview generation from thumbnail.

check installation directory

Campbell Barton (campbellbarton) accepted this revision.Feb 3 2022, 11:25 AM

install

This revision is now accepted and ready to land.Feb 3 2022, 5:18 PM

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Feb 3 2022, 5:19 PM

Ankit Meel (ankitm) added 1 blocking reviewer(s): Platform: macOS.

Ankit Meel (ankitm) added a project: Platforms, Builds, Tests & Devices.

This revision now requires review to proceed.Feb 3 2022, 5:19 PM

I'd prefer to leave building this off by default, since it doesn't actually integrate with macOS thumbnails in this state.

To actually make this work I guess we need to follow this:
https://developer.apple.com/documentation/quicklookthumbnailing/providing_thumbnails_of_your_custom_file_types

But it's not clear to me if that would be part of the existing Blender executable, or a separate library or executable.

This revision now requires changes to proceed.Feb 4 2022, 2:15 PM

In D13997#373000, @Brecht Van Lommel (brecht) wrote:

I'd prefer to leave building this off by default, since it doesn't actually integrate with macOS thumbnails in this state.

agreed

To actually make this work I guess we need to follow this:
https://developer.apple.com/documentation/quicklookthumbnailing/providing_thumbnails_of_your_custom_file_types

Sadly this "QuickLook Thumbnailing" framework is available on 10.15 onwards.. for 10.13, 10.14 https://developer.apple.com/documentation/quicklook/previews_or_thumbnail_images_for_macos_10_14_or_earlier?language=objc should be used I think.
More info at https://developer.apple.com/library/archive/documentation/UserExperience/Conceptual/Quicklook_Programming_Guide/Introduction/Introduction.html#//apple_ref/doc/uid/TP40005020-CH1-SW1

deprecated but still usable.

But it's not clear to me if that would be part of the existing Blender executable, or a separate library or executable.

I'll have to check but .qlgenerator as a separate package can work too. blender-thumbnailer would still be useful since it outputs an image which is way better than trying to draw with Obj-C APIs.

I don't think we should spend time implementing a deprecated API to make old macOS versions work, that we will stop supporting anyway.

turn off by default
add comment

Brecht Van Lommel (brecht) accepted this revision.Feb 4 2022, 4:19 PM

This revision is now accepted and ready to land.Feb 4 2022, 4:19 PM

Closed by commit rB7331c86dbf3b: macOS: support building blender-thumbnailer (authored by Ankit Meel (ankitm)). · Explain WhyFeb 4 2022, 4:28 PM

This revision was automatically updated to reflect the committed changes.

Ankit Meel (ankitm) added a commit: rB7331c86dbf3b: macOS: support building blender-thumbnailer.