Fix :T94815 Drag to add node search prioritizes wrong node type
Needs ReviewPublic
Actions

Authored by Shrey Aggarwal (shrey_agg) on Feb 3 2022, 3:03 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T94815: Drag to add node search prioritizes wrong node type

Summary

The patch corrects the prority order of two socket nodes : "Combine HSV" and "Combine XYZ" when a Vector socket is dragged out.
Earlier the socket "Combine HSV" got a higher priority than the "Combine XYZ" in the pop-up menu.
This was only in the case if the dragged out socket was a Vector type.

Diff Detail

Repository: rB Blender

Event Timeline

Shrey Aggarwal (shrey_agg) requested review of this revision.Feb 3 2022, 3:03 AM

Shrey Aggarwal (shrey_agg) created this revision.

Shrey Aggarwal (shrey_agg) added a task: T94815: Drag to add node search prioritizes wrong node type.

Shrey Aggarwal (shrey_agg) edited the summary of this revision. (Show Details)Feb 3 2022, 3:11 AM

Thanks for the patch. I don't think adding a string comparison in this general function is the correct solution though.
I think a better solution is to add a special implementation of gather_link_search_ops to the offending combine node.

This revision now requires changes to proceed.Feb 4 2022, 12:40 AM

Implemented gather_link_search_ops function for CombineRGB, CombineXYZ and CombineHSV

Harbormaster completed remote builds in B20358: Diff 48006.Feb 5 2022, 10:11 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

intern/

socket_search_link.cc

9 lines

Diff 47896

View Options

source/blender/nodes/intern/socket_search_link.cc

Fix :T94815 Drag to add node search prioritizes wrong node typeNeeds ReviewPublicActions