Page MenuHome

Fix: Missing translations from operator descriptions
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Feb 4 2022, 7:06 AM.

Details

Summary

The strings in the get_description functions for operators need
translation, they are not found by the translation system automatically,
and there is no translation applied afterwards either (as far as I could
tell). Some used N_ before, but most did nothing.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Feb 4 2022, 7:06 AM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/editors/object/object_vgroup.c
3432–3476

Honestly I'm a bit skeptical that this would even work for many languages that don't order the words the same way.

Do you think it's worth getting rid of the formatting at the cost of some duplication?

LGTM, thanks for noticing this!

source/blender/editors/object/object_vgroup.c
3432–3476

Yes indeed, this is very likely to be fully broken in many non-English languages. Not to mention that unless translators actually go search for the code behind those strings, it's very unlikely they even realize they are linked in the PO file...

I would definitely get rid of this 'smart' printf, usage of formatted strings is always a problem for translations, and should be kept to a very minimum.

This revision is now accepted and ready to land.Feb 4 2022, 9:11 AM