intern/ghost/intern/GHOST_SystemWin32.cpp
171–174	codestyle: missing braces
173	We're mere milliseconds from the process ending, does hiding the console if it was visible really bring anything to the table at this point?

This revision now requires changes to proceed.Feb 4 2022, 6:02 PM

console.diff77 KBDownload

There's no lines being added or removed in this patch which is probably also why phab rejected it

I am getting this when using arc

Update the revision comments, then save and exit.
Exception
Editor exited with an error code (#1).

I ran this command
arc diff --update D14016.

What does it mean?

you probably don't have an editor environment variable set

Revised Updates

Harbormaster completed remote builds in B20352: Diff 47989.Feb 4 2022, 11:04 PM

Still some codestyle issues, but i'll fix those myself before landing, be sure to run make format in the source folder before submitting a diff next time.

This revision is now accepted and ready to land.Feb 4 2022, 11:11 PM

Chandrapal Singh (chandrapalSd) added a subscriber: Chandrapal Singh (chandrapalSd).Feb 6 2022, 2:21 PM

Closed by commit rBa5dd1bc53d4b: Fix T90868: Console window flash when exiting (authored by Shrey Aggarwal (shrey_agg), committed by Ray Molenkamp (LazyDodo)). · Explain WhyFeb 7 2022, 4:20 PM

This revision was automatically updated to reflect the committed changes.

Ray Molenkamp (LazyDodo) added a commit: rBa5dd1bc53d4b: Fix T90868: Console window flash when exiting.

Landed, congratulations on your first blender contribution!

Chandrapal Singh (chandrapalSd) awarded a token.Feb 8 2022, 4:44 AM