Fix T95531: Draw y axis values in Driver Editor
ClosedPublic
Actions

Authored by Leon Schittek (lone_noel) on Feb 5 2022, 11:32 PM.

Details

Reviewers

Julian Eisel (Severin)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T95531: Driver Editor UI - Y-axis numbers missing

Commits

rB6b8dde93b0ca: Fix T95531: Draw y axis values in Driver Editor
rBea3b2e873616: Fix T95531: Draw y axis values in Driver Editor

Summary

Draw the Y axis values before returning early when drawing the
Driver Editor.

The issue was introduced in rBb3431a88465db2433b46e1f6426c801125d0047d
to avoid drawing the playhead in the Driver Editor but also prevented
the text on the y axis from being drawn.

patch	master (broken)	2.93 (worked)

Diff Detail

Repository

rB Blender

Branch

arcpatch-D14022 (branched from master)

Build Status

Buildable 20880
Build 20880: arc lint + arc unit

Event Timeline

Leon Schittek (lone_noel) requested review of this revision.Feb 5 2022, 11:32 PM

Leon Schittek (lone_noel) created this revision.

Harbormaster completed remote builds in B20360: Diff 48009.Feb 5 2022, 11:32 PM

Leon Schittek (lone_noel) edited the summary of this revision. (Show Details)Feb 5 2022, 11:33 PM

Leon Schittek (lone_noel) added a project: User Interface.

Leon Schittek (lone_noel) added a task: T95531: Driver Editor UI - Y-axis numbers missing.Feb 5 2022, 11:37 PM

RedMser (RedMser) awarded a token.Feb 6 2022, 1:14 AM

Pablo Vazquez (pablovazquez) awarded a token.Feb 7 2022, 12:52 PM

Merge branch 'master'

Harbormaster completed remote builds in B20851: Diff 48939.Mar 6 2022, 2:23 PM

@Sybren A. Stüvel (sybren) @Julian Eisel (Severin) Hey, can you review and commit this please? Fixes a 3.1 showstopper.

Thx @Leon Schittek (lone_noel)

Philipp Oeser (lichtwerk) added a reviewer: Julian Eisel (Severin).Mar 7 2022, 11:20 AM

Sybren A. Stüvel (sybren) added a reviewer: Sybren A. Stüvel (sybren).Mar 7 2022, 4:14 PM

Sybren A. Stüvel (sybren) added a project: Animation & Rigging.

Thanks for the patch @Leon Schittek (lone_noel)! I'll modify it slightly before committing, so that also the scroll bars are drawn:

Only skip the scrubbing area when drawing drivers; include drawing the scrollbars as well.

Harbormaster completed remote builds in B20880: Diff 48980.Mar 7 2022, 4:21 PM

Sybren A. Stüvel (sybren) accepted this revision.Mar 7 2022, 4:23 PM

Sybren A. Stüvel (sybren) added 2 blocking reviewer(s): Julian Eisel (Severin), Sybren A. Stüvel (sybren).

Julian Eisel (Severin) accepted this revision.Mar 7 2022, 4:23 PM

This revision is now accepted and ready to land.Mar 7 2022, 4:23 PM

Closed by commit rBea3b2e873616: Fix T95531: Draw y axis values in Driver Editor (authored by Leon Schittek (lone_noel), committed by Sybren A. Stüvel (sybren)). · Explain WhyMar 7 2022, 4:26 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rBea3b2e873616: Fix T95531: Draw y axis values in Driver Editor.

Sybren A. Stüvel (sybren) added a commit: rB6b8dde93b0ca: Fix T95531: Draw y axis values in Driver Editor.Mar 7 2022, 5:08 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_graph/

space_graph.c

12 lines

Diff 48980

View Options

source/blender/editors/space_graph/space_graph.c

Fix T95531: Draw y axis values in Driver EditorClosedPublicActions