Some curve objects don't have an evaluated mesh at all, but line art
currently assumes that all curve objects have one before converting
it to a mesh internally. Fix this by checking if the curve object has an
evaluated mesh before skipping it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Oh I didn't know this is a problem. I guess it's probably also caused by curve displist rewrite stuff?
Code looks good.
Comment Actions
Actually, I think this will end up ignoring the "allow duplicates" option for any instance with an evaluated mesh.
I don't really think that option should exist in the first place, but I can think of a solution that will solve it and provide some other benefits too.
Comment Actions
Huh alright... The main purpose of it was to ignore particles to speed up calculation. I think there needs to be a more elegant solution as well 😅
Comment Actions
Actually, I think this change is fine and solved the given problem, my concern above is incorrect.
The remaining problem is that evalauted from non-mesh objects or evaluated curves from non-curve objects, etc. will be ignored if "Allow Duplicates" is off. That's a different problem though.
Huh alright... The main purpose of it was to ignore particles to speed up calculation.
In that case the particles could be split to a separate object or collection I think. But yeah, it's more up to the grease pencil team whether this option should exist or not.