This patch adds icons to the physic collision shapes.
Adding a new capsule shape 'mesh_capsule' icon which represent the shape better then the metaballs icon.
And replace the metaballs icon for the Blender collision shape.
Details
Details
- Reviewers
Bastien Montagne (mont29) Campbell Barton (campbellbarton) Sybren A. Stüvel (sybren) Porteries Tristan (panzergame) Jorge Bernal (lordloki) Mitchell Stokes (moguri) Angus Hollands (agoose77) - Commits
- rBScdb8bf0c9615: BGE: Add icons to collision shapes.
rBcdb8bf0c9615: BGE: Add icons to collision shapes.
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Actually I don't know if a patch with binary files in it works correctly from Phabricator. If not I will upload the blender_icons.svg, icon16_mesh_capsule.dat and icon32_mesh_capsule.dat here.
If it is better to split the patch into two please (one for BGE one for Blender) please let me know.
Comment Actions
Looks good to me.
I think that it would be better to make a commit with *.svg, *.dat and UI_icons.h and after another commit using the new icon in the rna part.
Comment Actions
This is saving from an older inkscape making 100's of unrelated changes to the XML, probably they can be removed.
| release/datafiles/blender_icons.svg | ||
|---|---|---|
| 38498 | Seems these changes aren't needed? Could all these just be stripped out? | |
Comment Actions
This is saving from an older inkscape making 100's of unrelated changes to the XML, probably they can be removed.
I think we don't see the text changes of the svg file in the commit.
The 100's of unrelated changes are by changing the zoom and position of the view.
Anyway, I manually deleted the unnecessary changes and the version info from the patch. I tested the modified patch with with Inkscape and made a compile test.
@Campbell. Is it necessary to split my path into two like Jorge suggest or not?
Comment Actions
@Thomas Szepe (hg1) : blender_icons.svg failed patch apply, can you fix this conflict ?