Page MenuHome
Differential D14050

Fix T91840: Don't create invalid links when inserting a node on a link.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 8 2022, 4:26 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T91840: Don't create invalid links when inserting a node on a link
Commits
rB06ac5992618a: Fix T91840: do not create invalid links when inserting a node

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 8 2022, 4:26 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B20415: Diff 48092.Feb 8 2022, 4:26 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).Feb 8 2022, 4:27 PM
Jacques Lucke (JacquesLucke) added a task: T91840: Don't create invalid links when inserting a node on a link.
Hans Goudey (HooglyBoogly) accepted this revision.Feb 8 2022, 5:55 PM

I didn't test this, but the code looks good to me.

source/blender/editors/space_node/node_relationships.cc
2427

It's weird that this function has such high-level parameters, maybe that can be changed in the future.

This revision is now accepted and ready to land.Feb 8 2022, 5:55 PM
Closed by commit rB06ac5992618a: Fix T91840: do not create invalid links when inserting a node (authored by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 9 2022, 11:19 AM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB06ac5992618a: Fix T91840: do not create invalid links when inserting a node.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
79 lines

Diff 48115

View Options

source/blender/editors/space_node/node_relationships.cc

Loading...