Fix T95612: Missing domain interpolation when setting output attribute.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 8 2022, 4:58 PM.

Details

Reviewers

Maniphest Tasks

T95610: Writing to an attribute that is also a vertexgroup results in black when used in a shader
T95611: Regression: Capture Attribute in Face Corner mode produces garbage data
T95612: Realize Instances crashes Blender (3.1, 3.2 is fine)

Commits

rB7313a84c5acb: Fix T95612: only overwrite existing attributes with matching domain and type

Summary

The issue happens when there is a domain mismatch between the output domain set in the node group and the domain of an existing attribute with the same name.
There are 2 possible ways to handle this, I'm not exactly sure which should be preferred yet:

Use the domain set in the node group.
Use the domain of the existing attribute.

With this patch, we only write into the an existing attribute if the domain and data type provided by the node group matches the existing attribute.

Fixes T95611, T95612, T95610

Diff Detail

Repository

rB Blender

Branch

overwrite-existing-attribute (branched from master)

Build Status

Buildable 20425
Build 20425: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 8 2022, 4:58 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B20417: Diff 48094.Feb 8 2022, 4:58 PM

Jacques Lucke (JacquesLucke) added a task: T95612: Realize Instances crashes Blender (3.1, 3.2 is fine).Feb 8 2022, 5:00 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Feb 8 2022, 5:03 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

We usually automatically convert data types, which would be more like option 1. Maybe it's better to be more consistent with that for non-builtin attributes? On the other hand, maybe changing the domain on the fly is unexpected.

Another option is this: For 3.1 this could behave the same way it did before the recent bug fix to this area, and for 3.2 we could implement an "Auto" option like all of the old named attributes nodes (which we can also have in the store named attribute node).
The "Auto" option would use the existing domain if possible, otherwise the point domain I suppose. Does that sound reasonable?

Hans Goudey (HooglyBoogly) mentioned this in T95611: Regression: Capture Attribute in Face Corner mode produces garbage data.Feb 8 2022, 5:32 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Feb 8 2022, 5:50 PM

Hans Goudey (HooglyBoogly) added a project: Geometry Nodes.

Hans Goudey (HooglyBoogly) added a task: T95611: Regression: Capture Attribute in Face Corner mode produces garbage data.

Jacques Lucke (JacquesLucke) mentioned this in T95610: Writing to an attribute that is also a vertexgroup results in black when used in a shader.Feb 9 2022, 10:37 AM