Refactoring of `BKE_library_id_can_use_idtype` to use filter_id.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Feb 9 2022, 1:05 PM.

Details

Reviewers

Bastien Montagne (mont29)

Maniphest Tasks

T95279: Remap multiple items in referenced data

Commits

rBbccdb143db13: Refactoring of `BKE_library_id_can_use_idtype` to use filter_id.

Summary

For an upcoming project we would want to match multiple id types in a
single go. To not replicate the implementation using other types we
introduce BKE_library_id_can_use_filter_id that returns all supported
types as a filter.

Not all ID types have a filter_id (ID_LI, ID_KE, ID_SCR) These
exceptions are not available in the filter_id function.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Feb 9 2022, 1:05 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B20431: Diff 48127.Feb 9 2022, 1:05 PM

Jeroen Bakker (jbakker) added 1 blocking reviewer(s): Bastien Montagne (mont29).Feb 9 2022, 1:06 PM

Jeroen Bakker (jbakker) added projects: Core, BF Blender (3.2).

Jeroen Bakker (jbakker) added a task: T95279: Remap multiple items in referenced data.

LGTM.

As a second step. I think those filter values by ID types should be defined in the IDTypeInfo structure, rather than in that 'hidden' function. But this can be done later/separately.

This revision is now accepted and ready to land.Feb 10 2022, 6:00 PM

Yes agree, although the part how to do that isn't really clear to me (how do we want that interface look like on a technical level. )

Closed by commit rBbccdb143db13: Refactoring of `BKE_library_id_can_use_idtype` to use filter_id. (authored by Jeroen Bakker (jbakker)). · Explain WhyFeb 11 2022, 8:24 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rBbccdb143db13: Refactoring of `BKE_library_id_can_use_idtype` to use filter_id..