Fix T95542: Dual Mesh crashes with 'bad meshes'
ClosedPublic
Actions

Authored by Wannes Malfait (Wannes) on Feb 9 2022, 7:25 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T95542: Crash when turning on Keep Boundary

Commits

rB82fc68ed90bf: Fix T95542: Dual Mesh crashes with some non-manifold vertices

Summary

The problem was that the code for sorting polygons around a vertex
assumed that it was a manifold or boundary vertex. However in some cases
the vertex could still be nonmanifold causing the crash. The cases where
the sorting fails are now detected and these vertices are then marked as
nonmanifold.

Diff Detail

Repository

rB Blender

Branch

dual_mesh_crash (branched from master)

Build Status

Buildable 20597
Build 20597: arc lint + arc unit

Event Timeline

Wannes Malfait (Wannes) requested review of this revision.Feb 9 2022, 7:25 PM

Wannes Malfait (Wannes) created this revision.

Harbormaster completed remote builds in B20452: Diff 48153.Feb 9 2022, 7:25 PM

Wannes Malfait (Wannes) added a task: T95542: Crash when turning on Keep Boundary.Feb 9 2022, 7:25 PM

Hans Goudey (HooglyBoogly) accepted this revision.Feb 15 2022, 10:48 PM

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/nodes/geometry/nodes/node_geo_dual_mesh.cc
452	It would be nice to have a "because" here, i.e. `The vertex is not manifold because ... ,`
663	Unrelated to this patch, but this should probably use `std::move`, to make sure the array isn't copied when it has been allocated.