Bug was introduced in D12167.
Reading input size from an input socket is not possible in tiled compositor before execution is initialized. A similar change was done for the base class, see BlurBaseOperation::init_data(),
Details
Details
- Reviewers
Jeroen Bakker (jbakker) - Maniphest Tasks
- T95413: Blur node Size input crash under certain condition.
- Commits
- rB1a0a22f95a22: Fix T95413: Blur node size input crash
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- master
- Build Status
Buildable 20454 Build 20454: arc lint + arc unit
Event Timeline
Comment Actions
I haven't tested this, but this could lead to artifacts when using variable sizes. determine_depending_area_of_interest isn't correct.
(eg use a rangemap node to convert the depth of the image to a blur size.)
I could be wrong, but would need some testing on my side before approving.
Note to self.
- What does GaussianBlurReferenceOperation do
I don't mind if the tiled compositor would become a bit slower for this commit as we want to phase it out eventually, but only if there isn't a clean alternative.
Comment Actions
I wasn't able to create the expected artifacts. And check some code paths and don't see any issue with this patch.
The performance loss isn't that noticeable.