Page MenuHome
Differential D14071

Cycles: Expose "Use MetalRT" checkbox
ClosedPublic
Actions

Authored by Michael Jones (michael_jones) on Feb 10 2022, 12:05 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBa44366a642bc: Cycles: Expose "Use MetalRT" checkbox
Summary

For curve-heavy scenes, memory consumption regressed when we switched from MetalRT to bvh2. Allow users to opt in to MetalRT to workaround this.

Diff Detail

Repository
rB Blender
Branch
blender-v3.1-release
Build Status
Buildable 20468
Build 20468: arc lint + arc unit

Event Timeline

Michael Jones (michael_jones) requested review of this revision.Feb 10 2022, 12:05 PM
Michael Jones (michael_jones) created this revision.
Harbormaster completed remote builds in B20468: Diff 48181.Feb 10 2022, 12:05 PM
Brecht Van Lommel (brecht) requested changes to this revision.Feb 10 2022, 12:42 PM
Brecht Van Lommel (brecht) added inline comments.
intern/cycles/blender/addon/properties.py
1378–1379

I suggest to change names to:

"MetalRT (Experimental)"
"Metal RT for ray tracing uses less memory for scenes which use curves extensively, and can give better performance in specific cases. However this support is experimental and some scenes may render incorrectly"

Assuming that's the current status.

This revision now requires changes to proceed.Feb 10 2022, 12:42 PM
Michael Jones (michael_jones) updated this revision to Diff 48193.Feb 10 2022, 4:48 PM
  • Update messaging of MetalRT checkbox
Harbormaster completed remote builds in B20479: Diff 48193.Feb 10 2022, 4:48 PM
Brecht Van Lommel (brecht) accepted this revision.Feb 10 2022, 6:12 PM
This revision is now accepted and ready to land.Feb 10 2022, 6:12 PM
Closed by commit rBa44366a642bc: Cycles: Expose "Use MetalRT" checkbox (authored by Michael Jones (michael_jones)). · Explain WhyFeb 10 2022, 6:32 PM
This revision was automatically updated to reflect the committed changes.
Michael Jones (michael_jones) marked an inline comment as done.
Michael Jones (michael_jones) added a commit: rBa44366a642bc: Cycles: Expose "Use MetalRT" checkbox.

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
addon/
12 lines
4 lines
device/
2 lines
2 lines
metal/
1 line

Diff 48181

View Options

intern/cycles/blender/addon/properties.py

Loading...
View Options

intern/cycles/blender/device.cpp

Loading...
View Options

intern/cycles/device/device.h

Loading...
View Options

intern/cycles/device/device.cpp

Loading...
View Options

intern/cycles/device/metal/device_impl.mm

Loading...