Cycles: Fix Metal kernel compilation for AMD GPUs
ClosedPublic
Actions

Authored by Michael Jones (michael_jones) on Feb 10 2022, 7:17 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB27d3140b1363: Cycles: Fix Metal kernel compilation for AMD GPUs

Summary

Workaround for a compilation issue preventing kernels compiling for AMD GPUs: Avoid problematic use of templates on Metal by making gpu_parallel_active_index_array a wrapper macro, and moving blocksize to be a macro parameter.

Diff Detail

Repository: rB Blender

Event Timeline

Michael Jones (michael_jones) requested review of this revision.Feb 10 2022, 7:17 PM

Michael Jones (michael_jones) created this revision.

Harbormaster completed remote builds in B20483: Diff 48207.Feb 10 2022, 7:17 PM

Alaska (Alaska) awarded a token.Feb 11 2022, 8:29 AM

Michael Jones (michael_jones) mentioned this in D14090: Cycles: Set min macOS versions for Metal on Apple Silicon and AMD GPUs.Feb 11 2022, 11:41 PM

Brecht Van Lommel (brecht) accepted this revision.Feb 11 2022, 11:51 PM

This revision is now accepted and ready to land.Feb 11 2022, 11:51 PM

Closed by commit rB27d3140b1363: Cycles: Fix Metal kernel compilation for AMD GPUs (authored by Michael Jones (michael_jones)). · Explain WhyFeb 11 2022, 11:53 PM

This revision was automatically updated to reflect the committed changes.

Michael Jones (michael_jones) added a commit: rB27d3140b1363: Cycles: Fix Metal kernel compilation for AMD GPUs.

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

device/

gpu/

kernel.h

14 lines

parallel_active_index.h

138 lines

Diff 48264

View Options

intern/cycles/kernel/device/gpu/kernel.h