Fix T95420: Cycles crash with stereo render and tiles
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Feb 10 2022, 8:34 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T95420: Regression: Crash on Stereoscopic Render

Commits

rBe2728a0056df: Fix T95420: Cycles crash with stereo render and tiles

Summary

For reasons unclear, destroying and then recreating a vertex buffer in the
render OpenGL context is affecting the immediate mode vertex buffer in the
draw manager OpenGL context.

Instead just create a single vertex buffer and use it for the lifetime of
the render OpenGL context. There's not really any need to have a separate
one per tile as far as I can tell.

Diff Detail

Repository

rB Blender

Build Status

Buildable 20485
Build 20485: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Feb 10 2022, 8:34 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B20485: Diff 48210.Feb 10 2022, 8:35 PM

Brecht Van Lommel (brecht) added a task: T95420: Regression: Crash on Stereoscopic Render.Feb 10 2022, 8:39 PM

There's not really any need to have a separate one per tile as far as I can tell.

Indeed. Initial idea was to avoid vertex_buffer_update for tiles which never change, but I never finished this. And is debatable benefit even.

Anyway, since using single vertex buffer solves issue, I'm perfectly fine with your patch! It still puzzles me though from the "what exact root cause of the issue is" point of view though.

This revision is now accepted and ready to land.Feb 11 2022, 10:01 AM

Closed by commit rBe2728a0056df: Fix T95420: Cycles crash with stereo render and tiles (authored by Brecht Van Lommel (brecht)). · Explain WhyFeb 11 2022, 2:35 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBe2728a0056df: Fix T95420: Cycles crash with stereo render and tiles.