Cycles: refactor to keep session thread alive for duration of session
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Feb 10 2022, 9:25 PM.

Details

Reviewers

Commits

rB6ec83afb1db8: Cycles: refactor to keep session thread alive for duration of session

Summary

Instead of creating and destroying threads when starting and stopping renders,
keep a single thread alive for the duration of the session. This makes it so all
display driver OpenGL resource allocation and destruction can happen in the same
thread.

This was implemented as part of trying to solve another bug, but it did not
help. Still I prefer this behavior, to eliminate potential future issues wit
graphics drivers or with future Cycles display driver implementations.

Diff Detail

Repository

rB Blender

Branch

keep-alive (branched from master)

Build Status

Buildable 20486
Build 20486: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Feb 10 2022, 9:25 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B20486: Diff 48212.Feb 10 2022, 9:25 PM

Sergey Sharybin (sergey) accepted this revision.Feb 11 2022, 10:20 AM

This revision is now accepted and ready to land.Feb 11 2022, 10:20 AM

Closed by commit rB6ec83afb1db8: Cycles: refactor to keep session thread alive for duration of session (authored by Brecht Van Lommel (brecht)). · Explain WhyFeb 11 2022, 2:35 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB6ec83afb1db8: Cycles: refactor to keep session thread alive for duration of session.

Testing this revision in Windows 11 using vs2019 debugger it causes an assertion fail on line 113 "assert(session_thread_state_ == SESSION_THREAD_WAIT);" when using preview render. The session start is being call more than once at the render preview update, since it is already rendering it will cause the assertion to fail. Only happens with preview render not final render.

This revision is now accepted and ready to land.Feb 12 2022, 11:11 PM

Thanks, I'll commit a fix for that. No need to re-open revisions for this though.

Brecht Van Lommel (brecht) mentioned this in rB65d4c58060ea: Fix Cycles assert in debug mode after recent changes.Feb 14 2022, 3:45 PM