Cycles: Set min macOS versions for Metal on Apple Silicon and AMD GPUs
ClosedPublic
Actions

Authored by Michael Jones (michael_jones) on Feb 11 2022, 5:32 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB40fce61a6abe: Cycles: enable Metal on AMD GPUs, set macOS minimum versions

Summary

Apple Silicon support enabled on macOS 12.2+
AMD support enabled on macOS 12.3+ (pending unblocking of GPU rendering on macOS x86_64 in class USERPREF_PT_system_cycles_devices)

This patch also fixes a device enumeration crash on certain AMD configs which was caused by over-release of MTLDevice objects.

Diff Detail

Repository

rB Blender

Branch

blender-v3.1-release

Build Status

Buildable 20501
Build 20501: arc lint + arc unit

Event Timeline

Michael Jones (michael_jones) requested review of this revision.Feb 11 2022, 5:32 PM

Michael Jones (michael_jones) created this revision.

Harbormaster completed remote builds in B20501: Diff 48248.Feb 11 2022, 5:32 PM

Michael Jones (michael_jones) edited the summary of this revision. (Show Details)Feb 11 2022, 5:36 PM

Brecht Van Lommel (brecht) mentioned this in rB8fb2926a536f: Cycles: show Metal device in preferences also on Intel Macs.Feb 11 2022, 5:58 PM

I've made the required change to the preferences in rB8fb2926a536f: Cycles: show Metal device in preferences also on Intel Macs.

For the release notes and documentation, can we say that all AMD cards that work with macOS 12.3 or newer are supported?

This revision is now accepted and ready to land.Feb 11 2022, 5:58 PM

Closed by commit rB40fce61a6abe: Cycles: enable Metal on AMD GPUs, set macOS minimum versions (authored by Michael Jones (michael_jones), committed by Brecht Van Lommel (brecht)). · Explain WhyFeb 11 2022, 7:45 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB40fce61a6abe: Cycles: enable Metal on AMD GPUs, set macOS minimum versions.

In D14090#375494, @Brecht Van Lommel (brecht) wrote:

I've made the required change to the preferences in rB8fb2926a536f: Cycles: show Metal device in preferences also on Intel Macs.

Thanks @Brecht Van Lommel (brecht). Note that D14081 (or equivalent) will also need to land to fix shader compiler crashes on AMD.

For the release notes and documentation, can we say that all AMD cards that work with macOS 12.3 or newer are supported?

The release notes look good. It's still early days for Metal generally, and obviously AMD will have had less exposure than Apple Silicon, but we will be monitoring any feedback from 3.1 and beyond.

Not related to AMD, but I would perhaps generalise the first bullet point to be "Apple Silicon" rather than "M1":

Apple Silicon computers running macOS 12.2 or newer

Apple computers with AMD graphics card running macOS 12.3 or newer

In D14090#375580, @Michael Jones (michael_jones) wrote:

Thanks @Brecht Van Lommel (brecht). Note that D14081 (or equivalent) will also need to land to fix shader compiler crashes on AMD.

Oh, I forgot that it did not land yet, will commit also then.