Paths

Table of Contentst

Differential D14107

Curves: Add experimental curves sculpt mode.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 14 2022, 12:34 PM.

Tags

None

Subscribers

Paul Larson (GeorgiaPacific)

Philipp Oeser (lichtwerk)

Details

Reviewers

Hans Goudey (HooglyBoogly)
Kévin Dietrich (kevindietrich)

Maniphest Tasks

T95768: Add sculpt mode to hair curves object.

Commits

rB07032dd21892: Curves: add initial sculpt mode

Summary

This adds a new sculpt mode to the experimental new (hair) curves object. Currently, this mode can only be entered and existed, nothing else.
The patch also adds the editors/curves/ directory for the new curves object, which will be necessary for many other things as well.

Note, I added a completely new mode (OB_MODE_SCULPT_CURVES), because OB_MODE_SCULPT seems to be rather specific to meshes, and reusing it doesn't seem worth the trouble (not sure what the benefit would be anyway, grease pencil uses OB_MODE_SCULPT_GPENCIL). For the new edit mode, we should probably reuse OB_MODE_EDIT, because it is not specific to any object type.

I had to add DNA_userdef_enums.h to make the patch compile with C++ (forward declaration of enums isn't allowed). This follows the same pattern that we use for other enums in dna.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 14 2022, 12:34 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B20542: Diff 48321.Feb 14 2022, 12:34 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Feb 14 2022, 12:44 PM

Jacques Lucke (JacquesLucke) added reviewers: Hans Goudey (HooglyBoogly), Kévin Dietrich (kevindietrich).

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Feb 14 2022, 12:51 PM

Jacques Lucke (JacquesLucke) added a task: T95768: Add sculpt mode to hair curves object..Feb 14 2022, 2:35 PM

I didn't bother testing because it doesn't do anything ;)

source/blender/blenkernel/BKE_context.h
123	`CTX_MODE_NUM` should be updated too, and based on searching for that, `data_mode_strings` needs to be updated too.

This revision is now accepted and ready to land.Feb 15 2022, 2:27 AM

Closed by commit rB07032dd21892: Curves: add initial sculpt mode (authored by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 15 2022, 12:34 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB07032dd21892: Curves: add initial sculpt mode.

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Feb 21 2022, 5:49 PM

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_view3d.py

4 lines

source/

blender/

1 line

blenkernel/

3 lines

intern/

29 lines

editors/

1 line

curves/

24 lines

intern/

70 lines

include/

17 lines

1 line

interface/

interface_icons.c

1 line

object/

8 lines

space_api/

2 lines

util/

1 line

makesdna/

DNA_object_enums.h

3 lines

DNA_userdef_enums.h

48 lines

DNA_userdef_types.h

34 lines

makesrna/

intern/

1 line

1 line

1 line

windowmanager/

intern/

wm_keymap_utils.c

3 lines

Diff 48355

release/scripts/startup/bl_ui/space_view3d.py

Loading...

source/blender/CMakeLists.txt

Loading...

source/blender/blenkernel/BKE_context.h

Loading...

source/blender/blenkernel/intern/context.c

Loading...

source/blender/editors/CMakeLists.txt

Loading...

source/blender/editors/curves/CMakeLists.txt

Loading...

source/blender/editors/curves/intern/curves_ops.cc

Loading...

source/blender/editors/include/ED_curves.h

Loading...

source/blender/editors/include/ED_object.h

Loading...

source/blender/editors/interface/interface_icons.c

Loading...

source/blender/editors/object/object_modes.c

Loading...

source/blender/editors/space_api/spacetypes.c

Loading...

source/blender/editors/util/CMakeLists.txt

Loading...

source/blender/makesdna/DNA_object_enums.h

Loading...

source/blender/makesdna/DNA_userdef_enums.h

Loading...

source/blender/makesdna/DNA_userdef_types.h

Loading...

source/blender/makesrna/intern/CMakeLists.txt

Loading...

source/blender/makesrna/intern/rna_context.c

Loading...

source/blender/makesrna/intern/rna_object.c

Loading...

source/blender/windowmanager/intern/wm_keymap_utils.c

Loading...