Paths

Table of Contentst

Differential D14114

Cleanup: Rename original curve object type enum
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Feb 15 2022, 4:44 AM.

Tags

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)
Jacques Lucke (JacquesLucke)

Commits

rBddf189892c59: Cleanup: Rename original curve object type enum

Summary

This commit renames enums related the "Curve" object type and ID type
to add _LEGACY to the end. The idea is to make our aspirations clearer
in the code and to avoid ambiguities between CURVE and CURVES.

To summarize for the records, the plans are:

In the short/medium term, replace the Curve object data type with Curves
In the longer term (no immediate plans), use a proper data block for 3D text and surfaces.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Feb 15 2022, 4:44 AM

Hans Goudey (HooglyBoogly) created this revision.

The renaming seems fine, although I'm wondering if we should also rename ID_CU to ID_CU_LEGACY since it's also similar to ID_CV.

Seems this patch misses renaming the enum it's self, getting a lot of errors error: ‘OB_CURVES_LEGACY’ undeclared (first use in this function); errors.

What Campbell says sounds reasonable to me.

Fine with me, I don't think you need me to review the details of this.

Futher renaming included in this update.

Sorry about the incomplete change. VS code was freezing when renaming, I guess I made the diff before it was done. The problem seems to be fixed in the latest release.

Accepting, I think it would be good to have a brief comment for OB_CURVES_LEGACY ID_CU_LEGACY mentioning they're still in use, referencing the task to replace them.

source/blender/makesdna/DNA_ID.h
1001 ↗	(On Diff #48447)	Note that `ID_CV` is intended to be used instead, reference the task.
source/blender/makesdna/DNA_object_types.h
474 ↗	(On Diff #48447)	This could include a note that `OB_CURVES_LEGACY` is still in use but will eventually be replaced by `OB_CURVES` with a link to the task.

This revision is now accepted and ready to land.Feb 17 2022, 8:38 AM

Closed by commit rBddf189892c59: Cleanup: Rename original curve object type enum (authored by Hans Goudey (HooglyBoogly)). · Explain WhyFeb 18 2022, 4:51 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBddf189892c59: Cleanup: Rename original curve object type enum.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

2 lines

4 lines

armature_update.c

2 lines

6 lines

2 lines

4 lines

2 lines

curve_convert.c

4 lines

4 lines

6 lines

4 lines

geometry_set.cc

2 lines

18 lines

8 lines

mesh_convert.cc

8 lines

2 lines

42 lines

object_dupli.cc

2 lines

object_update.c

2 lines

6 lines

4 lines

blenloader/

intern/

versioning_250.c

2 lines

versioning_legacy.c

2 lines

editors/

animation/

anim_channels_defines.c

2 lines

6 lines

curve/

16 lines

editcurve_add.c

4 lines

editcurve_undo.c

2 lines

gpencil/

gpencil_convert.c

4 lines

mesh/

editmesh_knife_project.c

2 lines

object/

32 lines

object_bake_api.c

2 lines

object_constraint.c

5 lines

8 lines

4 lines

2 lines

object_modifier.c

4 lines

object_relations.c

14 lines

object_transform.c

12 lines

2 lines

render/

render_shading.cc

4 lines

screen/

6 lines

space_buttons/

buttons_context.c

4 lines

space_info/

4 lines

space_node/

node_context_path.cc

2 lines

space_outliner/

outliner_draw.cc

2 lines

space_spreadsheet/

space_spreadsheet.cc

2 lines

space_view3d/

view3d_buttons.c

4 lines

2 lines

view3d_select.c

8 lines

transform/

2 lines

transform_convert.c

6 lines

transform_generics.c

3 lines

transform_gizmo_3d.c

2 lines

transform_gizmo_extrude_3d.c

2 lines

transform_mode.c

2 lines

transform_orientations.c

4 lines

transform_snap.c

6 lines

transform_snap_object.c

6 lines

util/

ed_transverts.c

7 lines

io/

alembic/

exporter/

abc_hierarchy_iterator.cc

2 lines

abc_writer_nurbs.cc

2 lines

intern/

abc_reader_curves.cc

6 lines

abc_reader_nurbs.cc

2 lines

usd/

intern/

usd_hierarchy_iterator.cc

2 lines

usd_reader_curve.cc

4 lines

usd_reader_nurbs.cc

4 lines

wavefront_obj/

exporter/

obj_exporter.hh

11 lines

obj_exporter.cc

2 lines

makesrna/

intern/

2 lines

modifiers/

intern/

2 lines

2 lines

MOD_ui_common.c

2 lines

2 lines

Diff 48345

source/blender/blenkernel/intern/action.c

Loading...

source/blender/blenkernel/intern/anim_path.c

Loading...

source/blender/blenkernel/intern/armature_update.c

Loading...

source/blender/blenkernel/intern/constraint.c

Loading...

source/blender/blenkernel/intern/context.c

Loading...

source/blender/blenkernel/intern/curve.cc

Loading...

source/blender/blenkernel/intern/curve_bevel.c

Loading...

source/blender/blenkernel/intern/curve_convert.c

Loading...

source/blender/blenkernel/intern/curve_deform.c

Loading...

source/blender/blenkernel/intern/displist.cc

Loading...

source/blender/blenkernel/intern/effect.c

Loading...

source/blender/blenkernel/intern/geometry_set.cc

Loading...

source/blender/blenkernel/intern/key.c

Loading...

source/blender/blenkernel/intern/material.c

Loading...

source/blender/blenkernel/intern/mesh_convert.cc

Loading...

source/blender/blenkernel/intern/modifier.c

Loading...

source/blender/blenkernel/intern/object.cc

Loading...

source/blender/blenkernel/intern/object_dupli.cc

Loading...

source/blender/blenkernel/intern/object_update.c

Loading...

source/blender/blenkernel/intern/softbody.c

Loading...

source/blender/blenkernel/intern/vfont.c

Loading...

source/blender/blenloader/intern/versioning_250.c

Loading...

source/blender/blenloader/intern/versioning_legacy.c

Loading...

source/blender/editors/animation/anim_channels_defines.c

Loading...

source/blender/editors/animation/anim_filter.c

Loading...

source/blender/editors/curve/editcurve.c

Loading...

source/blender/editors/curve/editcurve_add.c

Loading...

source/blender/editors/curve/editcurve_undo.c

Loading...

source/blender/editors/gpencil/gpencil_convert.c

Loading...

source/blender/editors/mesh/editmesh_knife_project.c

Loading...

source/blender/editors/object/object_add.c

Loading...

source/blender/editors/object/object_bake_api.c

Loading...

source/blender/editors/object/object_constraint.c

Loading...

source/blender/editors/object/object_edit.c

Loading...

source/blender/editors/object/object_hook.c

Loading...

source/blender/editors/object/object_modes.c

Loading...

source/blender/editors/object/object_modifier.c

Loading...

source/blender/editors/object/object_relations.c

Loading...

source/blender/editors/object/object_transform.c

Loading...

source/blender/editors/object/object_utils.c

Loading...

source/blender/editors/render/render_shading.cc

Loading...

source/blender/editors/screen/screen_ops.c

Loading...

source/blender/editors/space_buttons/buttons_context.c

Loading...

source/blender/editors/space_info/info_stats.cc

Loading...

source/blender/editors/space_node/node_context_path.cc

Loading...

source/blender/editors/space_outliner/outliner_draw.cc

Loading...

source/blender/editors/space_spreadsheet/space_spreadsheet.cc

Loading...

source/blender/editors/space_view3d/view3d_buttons.c

Loading...

source/blender/editors/space_view3d/view3d_draw.c

Loading...

source/blender/editors/space_view3d/view3d_select.c

Loading...

source/blender/editors/transform/transform.c

Loading...

source/blender/editors/transform/transform_convert.c

Loading...

source/blender/editors/transform/transform_generics.c

Loading...

source/blender/editors/transform/transform_gizmo_3d.c

Loading...

source/blender/editors/transform/transform_gizmo_extrude_3d.c

Loading...

source/blender/editors/transform/transform_mode.c

Loading...

source/blender/editors/transform/transform_orientations.c

Loading...

source/blender/editors/transform/transform_snap.c

Loading...

source/blender/editors/transform/transform_snap_object.c

Loading...

source/blender/editors/util/ed_transverts.c

Loading...

source/blender/io/alembic/exporter/abc_hierarchy_iterator.cc

Loading...

source/blender/io/alembic/exporter/abc_writer_nurbs.cc

Loading...

source/blender/io/alembic/intern/abc_reader_curves.cc

Loading...

source/blender/io/alembic/intern/abc_reader_nurbs.cc

Loading...

source/blender/io/usd/intern/usd_hierarchy_iterator.cc

Loading...

source/blender/io/usd/intern/usd_reader_curve.cc

Loading...

source/blender/io/usd/intern/usd_reader_nurbs.cc

Loading...

source/blender/io/wavefront_obj/exporter/obj_exporter.hh

Loading...

source/blender/io/wavefront_obj/exporter/obj_exporter.cc

Loading...

source/blender/makesrna/intern/rna_main_api.c

Loading...

source/blender/modifiers/intern/MOD_array.c

Loading...

source/blender/modifiers/intern/MOD_curve.c

Loading...

source/blender/modifiers/intern/MOD_ui_common.c

Loading...

source/blender/modifiers/intern/MOD_util.c

Loading...