Page MenuHome
Differential D1412

Add color property for text effect strip
AbandonedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Jul 17 2015, 2:36 AM.

Details

Reviewers
Felix Beuster (FBeuster)
Campbell Barton (campbellbarton)
Summary

White text on a white video would not read that well,
so now you can pick black, or any other different color,
for your text overlay.

Diff Detail

Repository
rB Blender

Event Timeline

Felix Beuster (FBeuster) updated this revision to Diff 4692.Jul 17 2015, 2:36 AM
Felix Beuster (FBeuster) retitled this revision from to Add color property for text effect strip.
Felix Beuster (FBeuster) updated this object.
Felix Beuster (FBeuster) added a reviewer: Campbell Barton (campbellbarton).
Felix Beuster (FBeuster) set the repository for this revision to rB Blender.
Felix Beuster (FBeuster) added a project: Video Sequencer.
Felix Beuster (FBeuster) added a subscriber: Antonis Ryakiotakis (psy-fi).Jul 17 2015, 4:52 PM
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).Jul 23 2015, 9:53 AM

Seems fine, but i'd rather have versioning code to be added so there's no regressions or so at all.

Campbell Barton (campbellbarton) edited edge metadata.Jul 23 2015, 9:53 AM

If the color can be selected, we probably want to be able to choose shadow color too?

Also theres no versioning code here, so existing files will have their color turned black.

Campbell Barton (campbellbarton) requested changes to this revision.Jul 23 2015, 9:55 AM
Campbell Barton (campbellbarton) edited edge metadata.
This revision now requires changes to proceed.Jul 23 2015, 9:55 AM
Felix Beuster (FBeuster) updated this revision to Diff 4747.Jul 24 2015, 4:30 PM
Felix Beuster (FBeuster) edited edge metadata.

Added versioning code to convert existing text effects. Also added a shadow color property.

Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Jan 25 2016, 8:25 PM

What is the status here @Campbell Barton (campbellbarton)

Felix Beuster (FBeuster) updated this revision to Diff 5900.Jan 26 2016, 1:59 AM
Felix Beuster (FBeuster) edited edge metadata.

Updated versioning code

Felix Beuster (FBeuster) updated this revision to Diff 5901.Jan 26 2016, 2:06 AM

removed debug leftover

Felix Beuster (FBeuster) added a comment.Jan 26 2016, 2:10 AM

From my perspective it still builds and works as intended, text and text shadow can be colored with this change.

Aaron Carlisle (Blendify) commandeered this revision.Apr 27 2016, 11:09 PM
Aaron Carlisle (Blendify) abandoned this revision.
Aaron Carlisle (Blendify) added a reviewer: Felix Beuster (FBeuster).

Something similar has been committed see rB0912bffb848dbb3fd13e736f1f60128e4a36a7f7

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
3 lines
source/
blender/
blenkernel/
intern/
7 lines
blenloader/
intern/
23 lines
makesdna/
2 lines
makesrna/
intern/
10 lines

Diff 5901

View Options

release/scripts/startup/bl_ui/space_sequencer.py

Loading...
View Options

source/blender/blenkernel/intern/seqeffects.c

Loading...
View Options

source/blender/blenloader/intern/versioning_270.c

Loading...
View Options

source/blender/makesdna/DNA_sequence_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_sequencer.c

Loading...