Page MenuHome

Nodes: Update dependency graph when removing some nodes
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Feb 15 2022, 8:09 PM.

Details

Summary

When removing a node that has a dependence on an ID, like the object
info node, the dependency graph relations weren't updated. This can
cause unexpected performance issues if a complex node tree continues
to depend on an ID that it doesn't actually use anymore. To fix this case,
tag relations for an update if the node has a data-block socket.

Fixes part of T88332

Diff Detail

Repository
rB Blender

Event Timeline

source/blender/blenkernel/intern/node.cc
2995

Should node->id be taken into account as well?

Take node->id into account

Hans Goudey (HooglyBoogly) retitled this revision from Nodes: Update dependency graph when removing node to Nodes: Update dependency graph when removing some nodes.Feb 17 2022, 6:14 AM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/intern/node.cc
2982

Now this name is outdated.

This revision is now accepted and ready to land.Feb 17 2022, 2:44 PM