Fix (unreported): Curve to Mesh: Don't create caps, when the rail curve is cyclic
ClosedPublic
Actions

Authored by Leon Schittek (lone_noel) on Feb 16 2022, 11:37 AM.

Details

Reviewers

Commits

rBddc52f2e1d0d: Fix: Curve to Mesh node creates caps when curve is cyclic

Summary

The "Fill Caps" option on the Curve to Mesh node introduced in
rBbc2f4dd8b408ee makes it possible to fill the open ends of the sweep
to create a manifold mesh.

This patch fixes an edge case, where caps were created even when the
rail curve (the curve used in the "Curve" input socket) was cyclic
making the resulting mesh non-manifold.

master (since 3.0)	patch

Test file shown above:

cyclic-curves-with-caps.blend870 KBDownload

Diff Detail

Repository

rB Blender

Branch

fix-unreported-cyclic-rail-curve-caps (branched from master)

Build Status

Buildable 20586
Build 20586: arc lint + arc unit

Event Timeline

Leon Schittek (lone_noel) requested review of this revision.Feb 16 2022, 11:37 AM

Leon Schittek (lone_noel) created this revision.

Harbormaster completed remote builds in B20586: Diff 48413.Feb 16 2022, 11:37 AM

Leon Schittek (lone_noel) edited the summary of this revision. (Show Details)Feb 16 2022, 11:40 AM

Leon Schittek (lone_noel) added a project: Geometry Nodes.

Leon Schittek (lone_noel) retitled this revision from Fix (unreported): Curve to Mesh node: don't create caps, when the rail curve is cyclic to Fix (unreported): Curve to Mesh: Don't create caps, when the rail curve is cyclic.Feb 16 2022, 9:12 PM

Leon Schittek (lone_noel) edited the summary of this revision. (Show Details)