Page MenuHome
Differential D14132

Cleanup: Move more cmake library variables to be advanced
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Feb 16 2022, 5:52 PM.

Details

Reviewers
Ray Molenkamp (LazyDodo)
Sybren A. Stüvel (sybren)
Commits
rBa04300c436d7: Cleanup: Move more cmake library variables to be advanced
Summary

I noticed that there were a few variables that should not be visible per default.
It seems to me to simply be an oversight, so I went ahead and cleaned them up.

I think these changes should be fine and not change anything.
But I wanted to pass it by the platform maintainers so I don't sneak this in.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Feb 16 2022, 5:52 PM
Sebastian Parborg (zeddb) created this revision.
Sybren A. Stüvel (sybren) accepted this revision.Feb 17 2022, 5:23 PM

LGTM, I trust that you ran it and it works :)

This revision is now accepted and ready to land.Feb 17 2022, 5:23 PM
Ray Molenkamp (LazyDodo) accepted this revision.Feb 17 2022, 5:26 PM

I don't see anything concerning either, give it a spin on the bots just to be sure before landing.

Closed by commit rBa04300c436d7: Cleanup: Move more cmake library variables to be advanced (authored by Sebastian Parborg (zeddb)). · Explain WhyFeb 17 2022, 6:43 PM
This revision was automatically updated to reflect the committed changes.
Sebastian Parborg (zeddb) added a commit: rBa04300c436d7: Cleanup: Move more cmake library variables to be advanced.
Ankit Meel (ankitm) mentioned this in D7693: CMake: Use mark as advanced for several library cache variables.Feb 22 2022, 6:45 AM

Revision Contents
Changeset List

PathSize
build_files/
cmake/
Modules/
4 lines
2 lines
8 lines
1 line
platform/
1 line
source/
blender/
io/
collada/
4 lines

Diff 48439

View Options

build_files/cmake/Modules/FindFFmpeg.cmake

Loading...
View Options

build_files/cmake/Modules/FindOSL.cmake

Loading...
View Options

build_files/cmake/Modules/FindOpenColorIO.cmake

Loading...
View Options

build_files/cmake/Modules/FindOpenImageDenoise.cmake

Loading...
View Options

build_files/cmake/platform/platform_unix.cmake

Loading...
View Options

source/blender/io/collada/CMakeLists.txt

Loading...