Differential D14136

Curves: add initial edit mode support
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on Feb 17 2022, 1:09 PM.

Tags

None

Subscribers

None

Details

Reviewers

Jacques Lucke (JacquesLucke)
Hans Goudey (HooglyBoogly)

Maniphest Tasks

T95769: Add edit mode to hair curves object

Commits

rB5f16e24cc9ac: Curves: add initial edit mode support

Summary

This adds initial support for edit mode for the experimental new curves
object. For now we can only toggle in and out of the mode, no real
interraction is possible.

This patch also adds empty menus in edit mode. Those were added mainly
to quiet warnings as the menus are programmatically added to the edit
based on the object type and context.

Diff Detail

Repository

Branch

curves_edit_mode (branched from master)

Build Status

Buildable 20613
Build 20613: arc lint + arc unit

Event Timeline

Kévin Dietrich (kevindietrich) requested review of this revision.Feb 17 2022, 1:09 PM

Kévin Dietrich (kevindietrich) created this revision.

Harbormaster completed remote builds in B20613: Diff 48459.Feb 17 2022, 1:09 PM

The changes make sense, and it also works in my basic test.

Not too much to say at this point, but the changes look good to me.

This revision is now accepted and ready to land.Feb 18 2022, 7:16 AM

Closed by commit rB5f16e24cc9ac: Curves: add initial edit mode support (authored by Kévin Dietrich (kevindietrich)). · Explain WhyFeb 18 2022, 11:31 AM

This revision was automatically updated to reflect the committed changes.

Kévin Dietrich (kevindietrich) added a commit: rB5f16e24cc9ac: Curves: add initial edit mode support.

Isaac Gicheha (Gicheha) mentioned this in T68981: New curves object type.Mar 19 2022, 9:15 AM

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_view3d.py

16 lines

source/

blender/

blenkernel/

1 line

intern/

3 lines

draw/

engines/

overlay/

overlay_engine.c

1 line

editors/

object/

4 lines

2 lines

space_view3d/

3 lines

makesdna/

DNA_object_types.h

2 lines

makesrna/

intern/

1 line

windowmanager/

1 line

intern/

wm_keymap_utils.c

3 lines

Diff 48459

release/scripts/startup/bl_ui/space_view3d.py

Loading...

source/blender/blenkernel/BKE_context.h

Loading...

source/blender/blenkernel/intern/context.c

Loading...

source/blender/draw/engines/overlay/overlay_engine.c

Loading...

source/blender/editors/object/object_edit.c

Loading...

source/blender/editors/object/object_modes.c

Loading...

source/blender/editors/space_view3d/space_view3d.c

Loading...

source/blender/makesdna/DNA_object_types.h

Loading...

source/blender/makesrna/intern/rna_context.c

Loading...

source/blender/windowmanager/WM_types.h

Loading...

source/blender/windowmanager/intern/wm_keymap_utils.c

Loading...