Page MenuHome
Differential D14137

macOS/CMake: install python based on WITH_PYTHON_INSTALL
Changes PlannedPublic
Actions

Authored by Ankit Meel (ankitm) on Feb 17 2022, 1:20 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Group Reviewers
Platform: macOS
Summary

seems to be a typo

Diff Detail

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Feb 17 2022, 1:20 PM
Ankit Meel (ankitm) created this revision.
Ankit Meel (ankitm) added reviewers: Platform: macOS, Campbell Barton (campbellbarton).Feb 18 2022, 10:35 AM
Ankit Meel (ankitm) added a project: Platforms, Builds, Tests & Devices.
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Feb 18 2022, 2:30 PM

As far as I can tell WITH_PYTHON_INSTALL=OFF on macOS is going to create a non-working build, unless WITH_PYTHON_MODULE or WITH_PYTHON_FRAMEWORK are ON.

So not sure what the purpose of this change is by itself. Better handling of linking to a system Python on macOS may be useful, but I'd rather see that done in one diff.

Ankit Meel (ankitm) planned changes to this revision.Feb 18 2022, 2:31 PM

Revision Contents
Changeset List

PathSize
source/
creator/
2 lines

Diff 48461

View Options

source/creator/CMakeLists.txt

Loading...