Page MenuHome
Differential D14155

Fix T93873: Broken UI of color socket input
AbandonedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Feb 19 2022, 10:39 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T93873: GeoNode color attribute swatch on modifier frontend behaves wrong
Summary

Fix T93873.

Patch limits the value between 0 to 1 for color socket input

BeforeAfter

Diff Detail

Repository
rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Feb 19 2022, 10:39 AM
Pratik Borhade (PratikPB2123) created this revision.
Pratik Borhade (PratikPB2123) added a reviewer: Hans Goudey (HooglyBoogly).
Pratik Borhade (PratikPB2123) added projects: Geometry Nodes, User Interface.
user1 (user1) mentioned this in T95907: GeoNodes modifier frontend color picker broken.Feb 20 2022, 11:54 AM
Trung Phạm (zNight) awarded a token.Feb 20 2022, 5:29 PM
Trung Phạm (zNight) added a subscriber: Trung Phạm (zNight).Feb 20 2022, 5:31 PM
Hans Goudey (HooglyBoogly) accepted this revision.Feb 21 2022, 6:44 PM
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/modifiers/intern/MOD_nodes.cc
457–458

I'll change these to 0.0 and 1.0 since they are doubles rather than integers.

This revision is now accepted and ready to land.Feb 21 2022, 6:44 PM
Hans Goudey (HooglyBoogly) added a comment.Feb 21 2022, 6:57 PM

Actually, I think it's better to just change the soft min and max here.

Hans Goudey (HooglyBoogly) abandoned this revision.Feb 21 2022, 7:03 PM

I ended up committing a slightly different change in rBbe6bcaa8c13dfca98e56d81afd3d19ba226c2699. Thanks for the patch.

Pratik Borhade (PratikPB2123) added a comment.Feb 22 2022, 3:07 AM

No problem. Thanks for the review :)

Pratik Borhade (PratikPB2123) added a comment.Feb 22 2022, 7:43 AM

@Hans Goudey (HooglyBoogly) hi, I don't understand why to limit mix-max from 0-infinity.
It broke the use of vertical slider when we manually enter value > 1

Hans Goudey (HooglyBoogly) added a comment.Feb 24 2022, 4:34 AM

As far as I know that's common behavior for most color button in Blender, in material properties for example.

Revision Contents
Changeset List

PathSize
source/
blender/
modifiers/
intern/
2 lines

Diff 48535

View Options

source/blender/modifiers/intern/MOD_nodes.cc

Loading...