Page MenuHome
Differential D14182

Curves: Add surface object pointer.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 23 2022, 4:18 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Brecht Van Lommel (brecht)
Maniphest Tasks
T95776: How to attach hair to a surface
Commits
rB6e11cfc56af4: Curves: add surface object pointer
Summary

Ref T95776.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 23 2022, 4:18 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B20705: Diff 48650.Feb 23 2022, 4:18 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Feb 23 2022, 4:19 PM
Jacques Lucke (JacquesLucke) added a task: T95776: How to attach hair to a surface.
Jacques Lucke (JacquesLucke) added reviewers: Hans Goudey (HooglyBoogly), Brecht Van Lommel (brecht).Feb 23 2022, 4:23 PM
Hans Goudey (HooglyBoogly) accepted this revision.Feb 24 2022, 6:07 PM

The comment is helpful, other than that, not much to comment on, besides the order of the panels.

release/scripts/startup/bl_ui/properties_data_curves.py
128

I'd order this below the attributes panel, which is more important IMO.

source/blender/makesrna/intern/rna_curves.c
272

Is the property not editable by default?

274

Mesh -> Mesh object

Brecht Van Lommel (brecht) accepted this revision.Feb 24 2022, 6:31 PM

No additional comments from me.

This revision is now accepted and ready to land.Feb 24 2022, 6:31 PM
Jacques Lucke (JacquesLucke) added inline comments.Feb 25 2022, 1:21 PM
source/blender/makesrna/intern/rna_curves.c
272

No, think PROP_POINTER are not editable by default or so.

Closed by commit rB6e11cfc56af4: Curves: add surface object pointer (authored by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 25 2022, 1:23 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB6e11cfc56af4: Curves: add surface object pointer.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
12 lines
source/
blender/
blenkernel/
intern/
3 lines
2 lines
makesdna/
9 lines
makesrna/
intern/
9 lines

Diff 48692

View Options

release/scripts/startup/bl_ui/properties_data_curves.py

Loading...
View Options

source/blender/blenkernel/intern/curves.cc

Loading...
View Options

source/blender/blenkernel/intern/lib_query.c

Loading...
View Options

source/blender/makesdna/DNA_curves_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_curves.c

Loading...