Page MenuHome

Fix T95963: change thresholds in complex solidify
ClosedPublic

Authored by Henrik Dick (weasel) on Feb 23 2022, 6:06 PM.

Details

Summary

Fix T95963

This fix contains two parts. There was one critical mistake where order of two indices was wrong when removing constraint planes from the array. The other changes are improvements to the used thresholds to keep everything numerically stable.

Diff Detail

Repository
rB Blender

Event Timeline

Henrik Dick (weasel) requested review of this revision.Feb 23 2022, 6:06 PM
Henrik Dick (weasel) created this revision.
  • lower the threshold to merge more normals

@Simon Thommes (simonthommes) I tried your new file in T95963 and there is still one little spike left on the bar. The artifact is clearly new and came from D14143. The problem with D14143 is that is does not handle non planar faces very well. I will have to think about a better solution for non planar faces, but that is out of the scope of this patch. I could increase the thresholds higher to hide the artifacts, but that will cause more and more inprecision in clean models with only planar faces. For your particular model the artifact dissappears if you triangulate your mesh using a triangulate modifier before solidify or if you use the even thickness mode.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2022, 12:26 PM
This revision was automatically updated to reflect the committed changes.