Page MenuHome
Differential D14188

Fix T95976: on cage GPU subdivision breaks X-ray selection
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on Feb 24 2022, 3:07 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rBb7a954218b0d: Fix T95976: on cage GPU subdivision breaks X-ray selection
Summary

When X-ray mode is active the selection is done using the mesh data to
select what is closest to the cursor. When GPU subdivision is active with
the "show on cage" modifier option, this fails as the mesh used for selection
is the unsubdivided one.

This creates a subdivision wrapper before running the selection routines to
ensure that subdivision is available on the CPU side as well.

Diff Detail

Repository
rB Blender
Branch
fix_T95976_gpu_subdivision_edit_mode_xray (branched from master)
Build Status
Buildable 20712
Build 20712: arc lint + arc unit

Event Timeline

Kévin Dietrich (kevindietrich) requested review of this revision.Feb 24 2022, 3:07 AM
Kévin Dietrich (kevindietrich) created this revision.
Harbormaster completed remote builds in B20712: Diff 48666.Feb 24 2022, 3:07 AM
Campbell Barton (campbellbarton) accepted this revision.Feb 24 2022, 5:43 AM
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/space_view3d/view3d_iterators.c
338

While obact works, use vc->obedit instead (which is also passed to editbmesh_get_eval_cage_from_orig).

This revision is now accepted and ready to land.Feb 24 2022, 5:43 AM
Closed by commit rBb7a954218b0d: Fix T95976: on cage GPU subdivision breaks X-ray selection (authored by Kévin Dietrich (kevindietrich)). · Explain WhyFeb 24 2022, 2:34 PM
This revision was automatically updated to reflect the committed changes.
Kévin Dietrich (kevindietrich) added a commit: rBb7a954218b0d: Fix T95976: on cage GPU subdivision breaks X-ray selection.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_view3d/
5 lines

Diff 48666

View Options

source/blender/editors/space_view3d/view3d_iterators.c

Loading...