Page MenuHome
Differential D1418

Replace MFace Usage by MLoopTri in meshlaplacian.c
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Jul 19 2015, 9:21 PM.

Details

Reviewers
Martin Felke (scorpion81)
Antonis Ryakiotakis (psy-fi)
Summary

This patch replaces MFaces by MLoopTris in meshlaplacian.c. Note: In order to use MLoopTris, a temporary DerivedMesh has to be created.
I am unsure whether Mesh itself is about to be changed from MFace to MLoopTri as well, thats why a temporary fix first.
Subtask of T45474 .

Diff Detail

Event Timeline

Martin Felke (scorpion81) updated this revision to Diff 4704.Jul 19 2015, 9:21 PM
Martin Felke (scorpion81) retitled this revision from to Replace MFace Usage by MLoopTri in meshlaplacian.c.
Martin Felke (scorpion81) updated this object.
Martin Felke (scorpion81) added reviewers: Campbell Barton (campbellbarton), Antonis Ryakiotakis (psy-fi).
Martin Felke (scorpion81) added a project: BF Blender: Next.
Campbell Barton (campbellbarton) requested changes to this revision.Jul 19 2015, 11:59 PM
Campbell Barton (campbellbarton) edited edge metadata.
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/armature/meshlaplacian.c
685–690

You don't need to use a derived-mesh, just calculate looptri's directly, see cdDM_getPBVH

This revision now requires changes to proceed.Jul 19 2015, 11:59 PM
Martin Felke (scorpion81) updated this revision to Diff 4706.Jul 20 2015, 12:40 AM
Martin Felke (scorpion81) edited edge metadata.

replaced DerivedMesh usage by direct calculation of MLoopTri

Martin Felke (scorpion81) marked an inline comment as done.Jul 20 2015, 12:42 AM

removed derivedmesh and calculating looptris directly

Campbell Barton (campbellbarton) mentioned this in rBe3f86c65803e: Replace MFace use by MLoopTri w/ heat-weighting.Jul 20 2015, 6:50 AM
Campbell Barton (campbellbarton) commandeered this revision.Jul 20 2015, 6:52 AM
Campbell Barton (campbellbarton) edited reviewers, added: Martin Felke (scorpion81); removed: Campbell Barton (campbellbarton).

Committed to master, noted some changes made.

source/blender/editors/armature/meshlaplacian.c
391–393

Better just to copy the points to the floats, instead of the floats themselves.

414

4 isnt referring to quads here.

586

Note, better do: mloop[mlt->tri[0]].v here.

Campbell Barton (campbellbarton) abandoned this revision.Jul 20 2015, 6:52 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
armature/
99 lines

Diff 4706

View Options

source/blender/editors/armature/meshlaplacian.c

Loading...