Fix potential crash during proxy building
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Feb 28 2022, 9:02 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T95688: Blender crashes randomly when editing video

Commits

rB4491c6226051: Fix potential crash during proxy building

Summary

Last step of proxy building caused crash due to thread race contition
when acessing ed->seqbase.

Looking at code, it seems that calling IMB_close_anim_proxies on
original strips is unnecessary so this code was removed to resolve this
issue.

Locking seqbase data may be possible, but it's not very practical as
many functions access this data on demand which can easily cause
program to freeze.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Feb 28 2022, 9:02 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B20760: Diff 48771.Feb 28 2022, 9:02 PM

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Feb 28 2022, 9:15 PM

Richard Antalik (ISS) mentioned this in T95688: Blender crashes randomly when editing video.Feb 28 2022, 9:20 PM

Richard Antalik (ISS) added a reviewer: Sergey Sharybin (sergey).

Richard Antalik (ISS) retitled this revision from Fix T95688: Crash during proxy building to Fix potential crash during proxy building.Mar 1 2022, 12:04 AM

Turns out that T95688 has been resolved already, but I still think, that seqbase should not be accessed from thread and even original strips could be freed during iteration.

Sergey Sharybin (sergey) accepted this revision.Mar 1 2022, 10:29 AM

This revision is now accepted and ready to land.Mar 1 2022, 10:29 AM

Closed by commit rB4491c6226051: Fix potential crash during proxy building (authored by Richard Antalik (ISS)). · Explain WhyMar 1 2022, 11:44 PM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB4491c6226051: Fix potential crash during proxy building.